Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers issue25057 #25058

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Resolve "Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers issue25057 #25058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/code/Magento/Newsletter/view/adminhtml/layout/newsletter_subscriber_block.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
<arguments>
<argument name="header" xsi:type="string" translate="true">Customer First Name</argument>
<argument name="index" xsi:type="string">firstname</argument>
<argument name="default" xsi:type="string">----</argument>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edenduong Do you think removing ---- and keeping this argument tag as it is without value would also solve the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kalpmehta : Yes, It can solve this issue. But I think it would be better if we remove it.
Thank you .

<argument name="header_css_class" xsi:type="string">col-first-name</argument>
<argument name="column_css_class" xsi:type="string">col-first-name</argument>
</arguments>
Expand All @@ -100,7 +99,6 @@
<arguments>
<argument name="header" xsi:type="string" translate="true">Customer Last Name</argument>
<argument name="index" xsi:type="string">lastname</argument>
<argument name="default" xsi:type="string">----</argument>
<argument name="header_css_class" xsi:type="string">col-last-name</argument>
<argument name="column_css_class" xsi:type="string">col-last-name</argument>
</arguments>
Expand Down