Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customer First Name" and "Customer Last Name" should display empty instead of "----" in Newsletter Subscribers #25057

Closed
edenduong opened this issue Oct 15, 2019 · 9 comments · Fixed by #25058
Assignees
Labels
Component: Backend Component: Newsletter Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@edenduong
Copy link
Contributor

edenduong commented Oct 15, 2019

Preconditions (*)

  1. Magento 2.3-develop

Steps to reproduce (*)

  1. Go to frontend, subscribe the newsletter with Guest
  2. Go to backend
  3. Marketing->Newsletter Subscribers
  4. Check the grid

"Customer First Name" and "Customer Last Name" should display empty instead of "----"

image

You can not search by "----". No results. So it should be empty

Expected result (*)

1."Customer First Name" and "Customer Last Name" should display empty

Actual result (*)

  1. "Customer First Name" and "Customer Last Name" display "----"
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @edenduong. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@edenduong do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@edenduong Customer First Name and Last Name display as ---- in exported CSV as you explain it is as empty.
image

@edenduong
Copy link
Contributor Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your Magento instance.
Admin access: https://i-25057-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@edenduong
Copy link
Contributor Author

Hi @krishprakash:

Sorry for my mistake. But, I think we should display it as "Empty" because we can not search "----". And the value is actually empty string. I updated the issue.

@krishprakash krishprakash added Component: Backend Component: Newsletter Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Oct 15, 2019
@ghost ghost unassigned krishprakash Oct 15, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 15, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-21819 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mohith227
Copy link
Contributor

mohith227 commented Oct 17, 2019

@magento-engcom-team I have found the solution and I have create pull request

@mohith227 mohith227 mentioned this issue Oct 21, 2019
4 tasks
@ghost ghost assigned mohith227 and unassigned mohith227 Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Component: Newsletter Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
4 participants