Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#25652: Arrows (.fotorama__thumb__arr) don't work in product gallery #25666

Merged
merged 1 commit into from
Nov 22, 2019
Merged

magento/magento2#25652: Arrows (.fotorama__thumb__arr) don't work in product gallery #25666

merged 1 commit into from
Nov 22, 2019

Conversation

alexey-rakitin
Copy link
Contributor

@alexey-rakitin alexey-rakitin commented Nov 20, 2019

Description (*)

Fotorama gallery thumbnails arrows now are shown if they are not disabled. So, if there are few thumbs, arrows will not be shown.

Fixed Issues (if relevant)

  1. Arrows (.fotorama__thumb__arr) don't work in product gallery #25652: Arrows (.fotorama__thumb__arr) don't work in product gallery

Manual testing scenarios (*)

  1. Navigate to product page
  2. Fotorama thumbnail arrows should not be visible, if they are disabled.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- Fotorama disabled arrows are hidden by opacity:0
- Internal ticket: MC-28947
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @alexey-rakitin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned kalpmehta Nov 21, 2019
@kalpmehta kalpmehta added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-6308 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Nov 22, 2019

Hi @alexey-rakitin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 22, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Dec 3, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 5, 2019
@VladimirZaets
Copy link
Contributor

Covered in the scope of #25915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants