Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrows (.fotorama__thumb__arr) don't work in product gallery #25652

Closed
adamvarga opened this issue Nov 19, 2019 · 13 comments
Closed

Arrows (.fotorama__thumb__arr) don't work in product gallery #25652

adamvarga opened this issue Nov 19, 2019 · 13 comments
Assignees
Labels
Area: Frontend Component: Catalog Component: MediaGallery Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@adamvarga
Copy link

adamvarga commented Nov 19, 2019

Preconditions (*)

  1. 2.3.3 Open Source and Commerce Edition with Sample Data

Steps to reproduce (*)

  1. Navigate to product page
  2. Check product with thumbnails in product gallery
  3. The little arrows don't work

Expected result (*)

  1. The arrows .fotorama__thumb__arr work or not existed, in previous version the arrows were not there

Actual result (*)

The little arrows next to the thumbs only make sense if there are more pictures than there is room for, although I only have 3 pictures, the arrows are displayed, which makes no sense.
I marked those with red circle on the screenshot.

Why are this litte arrows displayed? And if they ever appear, why don't work.
So either show and work, or hide completely.

fotorama_arrows_disabled

@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @adamvarga. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@adamvarga do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 19, 2019
@sudheers-kensium sudheers-kensium self-assigned this Nov 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @sudheers-kensium. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sudheers-kensium
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sudheers-kensium. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sudheers-kensium, here is your Magento instance.
Admin access: https://i-25652-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sudheers-kensium
Copy link
Contributor

@adamvarga This is not an issue, because you have only 3 images so arrows not displaying. If you have more images then arrows will display.

image

@adamvarga
Copy link
Author

adamvarga commented Nov 19, 2019

@sudheers-kensium The little arrows next to the thumbs only make sense if there are more pictures than there is room for, although I only have 3 pictures, the arrows are displayed, which makes no sense.
I marked those with red circle on the screenshot.

Why are this litte arrows displayed? And if they ever appear, why don't work. That is the question...
So either show and work, or hide completely. What do you think?

fotorama_arrows_disabled

@adamvarga
Copy link
Author

@sudheers-kensium I have removed a few product images from your test page (https://i-25652-2-3-develop.instances.magento-community.engineering/test.html). I have also only three image, the arrows are displayed anyway ...

Bildschirmfoto 2019-11-19 um 15 06 11

@sudheers-kensium sudheers-kensium added Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release and removed Progress: needs update labels Nov 19, 2019
@ghost ghost unassigned sudheers-kensium Nov 19, 2019
@magento-engcom-team
Copy link
Contributor

@sudheers-kensium Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 19, 2019
@sudheers-kensium sudheers-kensium added Component: MediaGallery Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sudheers-kensium
Thank you for verifying the issue. Based on the provided information internal tickets MC-28947 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 19, 2019
@vsevolod-tarasov vsevolod-tarasov self-assigned this Nov 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @vsevolod-tarasov. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @alexey-rakitin. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@VladimirZaets
Copy link
Contributor

Hi @adamvarga. Thank you for your report.
The issue has been fixed in #25666 by @alexey-rakitin in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

@VladimirZaets VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Catalog Component: MediaGallery Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants