eth_sendRawTransaction modifyed to support Ethereum transactions #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sriep
commented
Jun 4, 2019
•
Sriep
commented
- I added unit tests for any code that added
- I updated the CHANGELOG.md
- All IP is original and not copied from another source
- I assign all copyright to Loom Network for the code in the pull request
Load dposv3 when set in the loom.yml
* Fix cluster readiness check in e2e test runner Previous implementation didn't actually work properly. * Increase max retries to 5 while waiting for nodes to start up coin-2 really doesn't like starting up in timely fashion sometimes.
* Compress and move test data * Only include logs * Reorder
Wrong file name for OSX.
Force the ChainConfigManager to panic if it tries to enable a feature that's not supported by the current build. This should safely prevent the node from processing any further blocks in case a feature it doesn't support is activated by the rest of the chain. To make this work features now have a minimum build number associated with them, which must be specified by the ChainConfig contract owner when adding new features. The new functionality is not behind a feature flag, so once this is deployed to production new features can't be added until the whole cluster upgrades to a new build.
* URI support in e2e test runner * URI support in coin tests * Coin command migration to go-loom * URI FLag support in sendtx * URI support in util.go
A limiter is used to limit calls to karma+maxCalls(from loom.yaml) In the code the maxCalls factor was being added twice, once https://github.com/loomnetwork/loomchain/blob/4dfcbfd75d4afa618460d4501d1c56e0f5a561a5/throttle/karma-middleware.go#L132 here and again here when the Limiter is created. The net effect is that Call txs are not being limited effectively.
Use wait group.
This package is not relevant to the TM upgrade, its probably the remnant of some experiment.
Backport some fixes from newer Tendermint versions.
…nd non-plasma validators
`StoreState.Validators()` now returns either the current validator set from either the DPOS v3 contract, the DPOS v2, or from the TM genesis file if neither contract is enabled. `StoreState.Validators()` is hooked up to the `Validators()` function on the contract context. The ChainConfig contract has been refactored slightly to use `StoreState.Validators()` (via the contract context) instead of querying the DPOS contracts directly, the new behavior is behind a feature flag named `chaincfg:v1.1`. The DPOS v1 contract no longer calls `SetValidatorPower` via the contract context, this should a backwards compatible change since the validator power changes were never persisted to `app.db`, nor propagated to Tendermint.
minor improvments in reactor code
* move helper function to util.go * migrate delegations from plasma-* nodes to plasma-0 * add test for the migration of both delegations to plasma validators and non-plasma validators
When delegations that are getting redelegated get processed in distributeDelegatorRewards during the next election, the original delegation is essentially refunded to the delegator, and a new delegation with req.Amount goes into effect. So the net effect is that the delegator receives req.Amount in new money. Fixed by setting the state during redelegation to REDELEGATING, and updating the updateValidator to be the same as before
DPOS commands should now be executed via the loom CLI as follows: loom dposV2 <command> <args> loom dposV3 <command> <args>
Co-authored-by: Parth <[email protected]> Co-authored-by: Suhas <[email protected]> Co-authored-by: Mukul <[email protected]>
#1173) `debug set-app-height` command can be used to set the height the node should start replaying from on the next run.
github.com/tendermint/tmlibs/db was deprecated and github.com/tendermint/tendermint/libs/db should be used instead.
Previously block hashes were used as keys without being prefixed by anything, this may become a problem if we decide to add additional data to this DB, to make the DB a bit more future proof the block hash keys are no prefixed.
adding logging to reactor
- converting electime tests to use dposv3 fixing dposv3 elect-time tests reviving dpos downtime e2e test
* Wait for rewards delegation to unbond before withdrawing the rewards * specify Validator when calling CheckRewardDelegation * Update Makefile
…1145) Also remove support for in-process TG Oracles, that's only ever used in tests, in production each oracle runs as a separate process so that's what we should be testing.
|
Fix for #1177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.