Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check minimum build version before enabling feature flag #982

Merged
merged 11 commits into from
Apr 17, 2019
Merged

Check minimum build version before enabling feature flag #982

merged 11 commits into from
Apr 17, 2019

Conversation

pathornteng
Copy link
Contributor

@pathornteng pathornteng commented Apr 10, 2019 •
edited
Loading

  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

Issue: #915
go-loom: loomnetwork/go-loom#343

@pathornteng pathornteng self-assigned this Apr 11, 2019
@pathornteng pathornteng changed the title Prevent wrong build from corrupting app.db Check minimum build version before enabling feature flag Apr 11, 2019
enlight
enlight requested changes Apr 17, 2019
View reviewed changes
@enlight
Copy link
Contributor

enlight commented Apr 17, 2019

Note to self, decided against adding another feature flag to switch on this functionality, so once this is deployed to production we won't be able to add any new feature flags until everyone is on the new build.

@enlight enlight force-pushed the prevent-wrong-build-run branch from 9a065ca to d72a060 Compare April 17, 2019 16:39
enlight
enlight approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@enlight enlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enlight enlight merged commit e89b92f into master Apr 17, 2019
@enlight enlight deleted the prevent-wrong-build-run branch April 17, 2019 17:38
@enlight enlight mentioned this pull request Apr 24, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enlight enlight enlight approved these changes

Assignees

@pathornteng pathornteng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathornteng @enlight