minor improvments in reactor code #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ParthDesai
commented
Apr 22, 2019
•
ParthDesai
commented
- I added unit tests for any code that added
- I updated the CHANGELOG.md
- All IP is original and not copied from another source
- I assign all copyright to Loom Network for the code in the pull request
enlight
reviewed
Apr 23, 2019
fnConsensus/reactor.go
Outdated
| @@ -477,7 +472,7 @@ func (f *FnConsensusReactor) commit(fnID string) { | |||
| } | |||
|
|
|||
| if !currentVoteSet.HasConverged(f.cfg.FnVoteSigningThreshold, currentValidators) { | |||
| f.Logger.Info("No consensus achived", "VoteSet", currentVoteSet) | |||
| f.Logger.Info("No consensus achived", "fnID", fnID, "VoteSet", currentVoteSet, "Payload", currentVoteSet.Payload, "Response", currentVoteSet.Payload.Response) | |||
| @@ -402,6 +402,7 @@ func (f *FnConsensusReactor) vote(fnID string, fn Fn, currentValidators *types.V | |||
| votesetPayload := NewFnVotePayload(executionRequest, executionResponse) | |||
|
|
|||
| f.stateMtx.Lock() | |||
| defer f.stateMtx.Unlock() | |||
There was a problem hiding this comment.
This is fine. But what about the other mutexes you "manually" unlock like peerMapMtx, if there's a panic while trying to send to a peer it's never going to get unlocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.