Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_sendRawTransaction modified to handle Ethereum transactions #1177

Closed
Sriep opened this issue May 30, 2019 · 4 comments
Closed

eth_sendRawTransaction modified to handle Ethereum transactions #1177

Sriep opened this issue May 30, 2019 · 4 comments
Assignees
@Sriep
Labels
bug Something isn't working

Comments

@Sriep
Copy link
Contributor

Sriep commented May 30, 2019 •
edited
Loading

eth_sendRawTransaction, expects the input to be a TM tx, which isn't very useful because Web3 compatible clients don't send TM txs. We want that endpoint to accept Eth txs from any Web3 compatible client.
@Sriep
Copy link
Contributor Author

Sriep commented May 30, 2019

We need to support Ethreum format transactions.
https://ethereum.stackexchange.com/questions/1990/what-is-the-ethereum-transaction-data-structure
https://github.com/loomnetwork/go-ethereum/blob/loomchain/core/types/transaction.go#L38

@Sriep Sriep added the bug Something isn't working label May 30, 2019
@Sriep Sriep self-assigned this May 30, 2019
This was referenced Jun 3, 2019
Merged
Closed
@Sriep
Copy link
Contributor Author

Sriep commented Jun 4, 2019

Addressed in #1199

@Sriep Sriep mentioned this issue Jun 13, 2019
Merged
4 tasks
@Sriep
Copy link
Contributor Author

Sriep commented Jun 13, 2019

Fixed by #1227 and loomnetwork/go-loom#391

@enlight
Copy link
Contributor

enlight commented Oct 21, 2019

Resolved

@enlight enlight closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sriep Sriep

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enlight @Sriep