eth_sendRawTransaction modified to support ethereum transactions #1227

Sriep · 2019-06-13T11:59:50Z

I added unit tests for any code that added
I updated the CHANGELOG.md
All IP is original and not copied from another source
I assign all copyright to Loom Network for the code in the pull request

Fix for #1177
Changes to support Ethereum transactions
Requires loomnetwork/go-loom#391
Changes to allow access to auth.Config information to determine Chain id. #1348
Add new feature flag EthTxFeature to activate ethereum transaction functionality.

enlight

I think we can do this without a new tx handler (EthTxHandler), new tx ID (4), nor any protobuf changes, here how:

Change VerifySolidity66Byte to check if len(SignedTx.Signature) == 0 if it is assume this is a raw Ethereum tx and use similar code to VerifyEthereumTransacton to recover the sender address.
Use the eth chain ID instead of native-eth when creating the SignedTx in ethereumToTendermintTx

rpc/tenderming.go

rpc/tendermint_handler.go

Sriep · 2019-07-04T10:08:11Z

Creating a new Tx id was so that vm.handler.go.ProcessTx knew how to unwrap the MessageTx.Data object. Is it an DeployTx, CallTx or rpl-wrapped-Ethereum-Transaction object
Alternatives to a new Tx id for an ethereum-transaction are.

Somewhere, maybe VerifySolidity66Byte the transaction self-modifies itself so that messageTx.Data field is converted into a DeplyTx or CallTx, losing the singing information just keeping the Code/Input data.
In vm.handler.go.ProcessTx if unmarshalling messageTx.Data as a DeplyTx or CallTx fails with an error, we have a stab as rlp.Decoding it. Only returning en error if both attempts fail. I'll code this for the moment.
We could intorduce a flag somewhere to indicate how to unwarp messageTx.Data, but really that is much the same as adding a new Tx Id.

# Conflicts: # e2e/eth-5-test.toml # eth/query/tx.go # rpc/query_server.go

Doesn't quite work yet because the signer on the node seems to have a different chain ID to the one recovered from the signed eth tx.

# Conflicts: # eth/polls/polls_test.go

# Conflicts: # features/features.go

Also revert the Ethereum ChainConfig changes since these are no longer needed in this PR. And tweak the truffle test a bit.

It was attempting to mint the same ERC721 UID as one of the other tests, which failed because you can't mint the same token twice.

These tests were using eth_getTransactionCount to obtain the account nonce, this method now expects to be given an Ethereum address instead of a DAppChain address. To fix this an account mapping is now created prior to the each nonce test case and the Ethereum address is used in calls to eth_getTransactionCount.

This RPC function wasn't reusable in any way, so renamed it to make it more obvious what it actually does.

So there's no need to bypass EthTxHandler in CheckTx, in fact we want it to run in CheckTx so it can do the basic validation checks.

Sriep

One suggestion, Looks ok to merge.

rpc/eth_rpc_funcs.go

eth_sendRawTransaction

38bed5c

This was referenced Jun 13, 2019

Add new EthTx for ethereum transactions. loomnetwork/go-loom#391

Merged

eth_sendRawTransaction modified to handle Ethereum transactions #1177

Closed

Sriep requested a review from enlight June 13, 2019 12:04

use correct go-loom

dd1b486

Sriep changed the title ~~eth_sendRawTransaction~~ eth_sendRawTransaction modified to support ethereum transactions Jun 13, 2019

Sriep added 4 commits June 17, 2019 09:29

Merge remote-tracking branch 'remotes/origin/master' into issue1177

d227392

Merge remote-tracking branch 'remotes/origin/master' into issue1177

f7ae453

new go loom versoin

89815ef

Merge remote-tracking branch 'remotes/origin/master' into issue1177

7ca8174

enlight requested changes Jul 3, 2019

View reviewed changes

rpc/tenderming.go Outdated Show resolved Hide resolved

rpc/tendermint_handler.go Outdated Show resolved Hide resolved

rpc/tendermint_handler.go Outdated Show resolved Hide resolved

Sriep added 7 commits July 3, 2019 14:02

Merge remote-tracking branch 'remotes/origin/master' into issue1177

d58f4ff

msg -> tx

56ec782

Remove EthTx

8a71639

Fix tx id

c30a3d2

use go-loom head

5e1c3fb

Merge remote-tracking branch 'remotes/origin/master' into issue1177

ff918f4

Use DecodeBytes not MarshalJSON

dfd09ac

Sriep added 10 commits July 4, 2019 15:56

add txid = 4

f5d6437

tx id start 1

320392e

unit test

f159019

unit test

9659aae

eth tx not plugin

db36085

fix enum

ca25e28

remove debug line

f603bf1

Merge remote-tracking branch 'remotes/origin/master' into issue1177

5407728

touch

483e7fc

merge master

864b94b

enlight added 22 commits October 3, 2019 12:19

Merge branch 'master' into issue1177

165cbda

# Conflicts: # e2e/eth-5-test.toml # eth/query/tx.go # rpc/query_server.go

Move EthTxHandler to tx_handler package

af2fd75

Eliminate LoomServer, TendermintRpc, RuntimeTendermintRpc

b796efd

Fix test

c642c42

Fix test

2e3a850

Add an truffle test for eth_sendRawTransaction

d65e14d

Doesn't quite work yet because the signer on the node seems to have a different chain ID to the one recovered from the signed eth tx.

Merge branch 'master' into issue1177

2c2091d

# Conflicts: # eth/polls/polls_test.go

Remove the e2e test that was replaced by a Truffle test

645fb06

Fix a few linter issues

2cf0019

Merge branch 'master' into issue1177

683f98b

# Conflicts: # features/features.go

Set signer chain ID to match the one used by the client when signing tx

3058926

MakeSigner -> NewEIP155Signer

5ff782f

Also revert the Ethereum ChainConfig changes since these are no longer needed in this PR. And tweak the truffle test a bit.

Fix truffle test

963ab12

It was attempting to mint the same ERC721 UID as one of the other tests, which failed because you can't mint the same token twice.

Fix multi chain signing middleware to prevent consensus failure

116efc1

TendermintRPCFunc -> SendRawTransactionRPCFunc

299e29a

This RPC function wasn't reusable in any way, so renamed it to make it more obvious what it actually does.

Fix tests

3055835

Fix test

ed43b88

Cleanup error handling in EthTxHandler

3ee280e

Fix feature name

6623188

EthTxHandler only does basic validation in CheckTx

2a2cff4

So there's no need to bypass EthTxHandler in CheckTx, in fact we want it to run in CheckTx so it can do the basic validation checks.

Switch back to go-loom master

ed75cea

Sriep commented Oct 15, 2019

View reviewed changes

rpc/eth_rpc_funcs.go Outdated Show resolved Hide resolved

enlight added 4 commits October 15, 2019 23:03

Encode chain ID only once in SendRawTransactionPRCFunc

073fc3f

Cleanup

3723338

Tweak SendRawTransactionRPCFunc one more time

1f17287

Cleanup

6c3181d

enlight merged commit d36e3dc into master Oct 15, 2019

enlight deleted the issue1177 branch February 27, 2020 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eth_sendRawTransaction modified to support ethereum transactions #1227

eth_sendRawTransaction modified to support ethereum transactions #1227

Sriep commented Jun 13, 2019 •

edited

Loading

enlight left a comment

Sriep commented Jul 4, 2019 •

edited

Loading

Sriep left a comment •

edited

Loading

eth_sendRawTransaction modified to support ethereum transactions #1227

eth_sendRawTransaction modified to support ethereum transactions #1227

Conversation

Sriep commented Jun 13, 2019 • edited Loading

enlight left a comment

Choose a reason for hiding this comment

Sriep commented Jul 4, 2019 • edited Loading

Sriep left a comment • edited Loading

Choose a reason for hiding this comment

Sriep commented Jun 13, 2019 •

edited

Loading

Sriep commented Jul 4, 2019 •

edited

Loading

Sriep left a comment •

edited

Loading