Use alternate names for blacklist/whitelist in prow

[spiffxp]

What should be cleaned up or changed:
There are sundry files within prow that can probably use more specific terms, or the generic terms "allowlist/denylist"

$ ag -l whitelist\|blacklist prow | sort
prow/ANNOUNCEMENTS.md # ignore, deprecation announcements
prow/cmd/exporter/collector.go
prow/cmd/exporter/collector_test.go
prow/cmd/hook/main.go
prow/cmd/status-reconciler/main.go # offending flag has been deprecated
prow/cmd/status-reconciler/main_test.go
prow/config/config.go
prow/config/prow-config-documented.yaml
prow/hook/hook_test.go
prow/plugins/approve/approve_test.go
prow/plugins/blunderbuss/blunderbuss_test.go
prow/plugins/config.go
prow/plugins/lgtm/lgtm_test.go
prow/plugins/plugin-config-documented.yaml
prow/plugins/verify-owners/verify-owners.go
prow/plugins/verify-owners/verify-owners_test.go
prow/repoowners/repoowners.go
prow/repoowners/repoowners_test.go

EDIT: pulling up from #19264 (comment)

All instances of whitelist have been removed from prow (thanks @chases2!). blacklist appears in two config fields that would need to be deprecated:

• OwnersDirBlackList, in the Prow config
• LabelsBlacklist, in the Prow plugins config

Provide any links for context:

/area prow
/wg naming
/sig testing

[justaugustus]

Needs a rec proposed for replacement.
cc: @kubernetes/wg-naming

[justaugustus]

/help

[k8s-ci-robot]

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justaugustus]

For ADR:
/assign @celestehorgan

For advice on impl:
/assign @justaugustus

[justaugustus]

ADR up for review: kubernetes/community#5341

[chases2]

I went through the files in the prow dir and renamed the easier ones. I managed to remove all of the instances of "whitelist", but "blacklist" has two configurations that would need to be deprecated:

• OwnersDirBlackList, in the Prow config
• LabelsBlacklist, in the Prow plugins config

Also notable:

• The file ANNOUNCEMENTS.md contains deprecation announcements, which shouldn't be changed.
• status-reconciler has already had its flag deprecated, with a tombstone date of June 1st.
  • After June 1st, delete the flag

[spiffxp]

ref: #18801 (covered slack mergewarning plugin)

[chaodaiG]

/assign

[chaodaiG]

#21577 and #21580 are for deprecating the remaining two "blacklist" config fields

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[spiffxp]

/milestone v1.23
/remove-lifecycle stale
I think what is keeping this open is that we are waiting to run down the deprecation clock so we can remove the old fields

[k8s-ci-robot]

@BenTheElder:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/lifecycle frozen
/good-first-issue
#19264 (comment) should be pretty straightforward, this ought to be a decent starter issue.

You will need to remove the deprecated fields and there associated code, and perhaps double check if we've missed any documentation references. There also needs to be a note in the announcements that they are now removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

wg/naming was dissolved.
Clearing assignees so it's clear that no-one is working on this.

If anyone is interested, please feel free to reach out to me or @chaodaiG, we can help answer any questions.

[vinayakshnd]

/assign

[harshitasao]

Hi, @BenTheElder. If no one else is working, can I work on this issue?

[adhishmeena]

Hi , @chaodaiG Please share the update regarding this issue. I would like to work on this issue

[BenTheElder]

Hi all, please feel free to work on this. You don't need to ask us for permission, but you might want to coordinate to avoid overlapping work.

I think this is almost done, but not fully removed yet https://cs.k8s.io/?q=blacklist&i=nope&files=&excludeFiles=&repos=kubernetes/test-infra

[harshitasao]

@adhishmeena If that's okay with you, I'll go ahead and work on this.

[harshitasao]

Hey @BenTheElder, I have made changes to all the required files. However,

1. I'm not sure if I should remove the code or modify it here.

2. Also, I'm not sure how to make changes to this function.

Can you please help me out?
Thank you.

[BenTheElder]

1. should be removed when the blacklist field is removed since there's no longer another flag to be exclusive with

2. should remove the second line of the method appending.

[harshitasao]

Thank you so much.

[harshitasao]

@BenTheElder, can you please suggest where I should put the note in the ANNOUNCEMENTS.md
Thank you.

[BenTheElder]

Under "Breaking Changes" since it is still a breaking change to remove them.
The entries are chronological with the current entry at the top. The prow versions are date + commit hash.

[harshitasao]

Got it. Thanks again.

[CypherpunkSamurai]

Hello Everyone, Is this issue still active?

I'm new to open-source and would like to contribute to this issue :)

[spiffxp]

/close
Only mentions left are in job configs or announcements describing the migration to allowlist/denylist

$ rg -il 'blacklist|whitelist'
config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml
config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-postsubmits.yaml
prow/ANNOUNCEMENTS.md

[k8s-ci-robot]

@spiffxp: Closing this issue.

In response to this:

/close
Only mentions left are in job configs or announcements describing the migration to allowlist/denylist

$ rg -il 'blacklist|whitelist'
config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml
config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-postsubmits.yaml
prow/ANNOUNCEMENTS.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.