Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternate internal comments/vars from whitelist/blacklist #20616

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

chases2
Copy link
Contributor

@chases2 chases2 commented Jan 26, 2021

xref #19264

I tried to be context-sensitive in choosing new names, trying to best reflect the idea the comment/variable is trying to convey.

This PR doesn't cover files that change Prow Config options; those changes will require deprecations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/tide Issues or PRs related to prow's tide component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 26, 2021
@chases2 chases2 requested a review from spiffxp January 26, 2021 23:58
@chases2 chases2 changed the title Use alternate internal comments/vars from whitelist/blacklist [WIP] Use alternate internal comments/vars from whitelist/blacklist Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2021
@chases2 chases2 changed the title [WIP] Use alternate internal comments/vars from whitelist/blacklist Use alternate internal comments/vars from whitelist/blacklist Jan 27, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2021
@chases2
Copy link
Contributor Author

chases2 commented Jan 27, 2021

Running bazel test in verify-owners fails flagrantly when I try to run it locally, but the same failures don't show up when Prow runs the tests (even without my changes).

Is the git stub being used in them not working locally? Or do I have some build artifact out of place?
verify-owners_test.go:1242: Switching to master branch: /usr/bin/git [checkout master]: exit status 1, error: pathspec 'master' did not match any file(s) known to git

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ff8f184 into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 28, 2021

/wg naming

@k8s-ci-robot k8s-ci-robot added the wg/naming Categorizes an issue or PR as relevant to WG Naming. label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/tide Issues or PRs related to prow's tide component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants