Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed all the deprecated fields and their associated codes. #26341

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Removed all the deprecated fields and their associated codes. #26341

merged 4 commits into from
Jun 27, 2022

Conversation

harshitasao
Copy link
Contributor

Part of #19264

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @harshitasao!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @harshitasao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot requested review from matthyx and MushuEE May 17, 2022 03:46
@k8s-ci-robot k8s-ci-robot added area/gubernator Issues or PRs related to code in /gubernator area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/status-reconciler Issues or PRs related to reconciling status when jobs change sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 17, 2022
@matthyx
Copy link
Contributor

matthyx commented May 18, 2022

Welcome @harshitasao !
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2022
@harshitasao harshitasao mentioned this pull request May 27, 2022
Closed
9 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2022
@matthyx
Copy link
Contributor

matthyx commented Jun 7, 2022

@harshitasao I don't think you can modify prow/ANNOUNCEMENTS.md anymore.

@harshitasao
Copy link
Contributor Author

My apologies, @matthyx could you please guide me through what I should do next?

@matthyx
Copy link
Contributor

matthyx commented Jun 10, 2022

My apologies, @matthyx could you please guide me through what I should do next?

Just revert your changes to this particular file... I am not sure if we need an announcement for that task anyways.

@harshitasao
Copy link
Contributor Author

Thank you. I will revert the changes.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jun 16, 2022
@matthyx
Copy link
Contributor

matthyx commented Jun 16, 2022

cheers!
/lgtm
/assign @chaodaiG

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
chaodaiG
chaodaiG requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! one comment

prow/plugins/config.go Outdated
if c.Owners.LabelsBlackList != nil && c.Owners.LabelsDenyList != nil {
return errors.New("labels_blacklist and labels_denylist cannot be both supplied")
if c.Owners.LabelsDenyList != nil {
return errors.New("labels_denylist cannot be supplied")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be incorrect. labels_denylist could be supplied, am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this up. I think labels_denylist could be supplied. So I will make the required changes.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@harshitasao harshitasao requested a review from chaodaiG June 23, 2022 06:44
@chaodaiG
Copy link
Contributor

LGTM, there are 4 commits in this PR now, and the commit messages don't suggest that they should be separate commits, so:
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, harshitasao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4644e62 into kubernetes:master Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 27, 2022
@harshitasao harshitasao deleted the issue-part-19264 branch June 30, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG chaodaiG approved these changes

@matthyx matthyx Awaiting requested review from matthyx

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@matthyx matthyx

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gubernator Issues or PRs related to code in /gubernator area/prow/hook Issues or PRs related to prow's hook component area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow/status-reconciler Issues or PRs related to reconciling status when jobs change area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@harshitasao @k8s-ci-robot @matthyx @chaodaiG