Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace owners_dir_blacklist with owners_dir_denylist #21577

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Replace owners_dir_blacklist with owners_dir_denylist #21577

merged 1 commit into from
Apr 6, 2021

Conversation

chaodaiG
Copy link
Contributor

Part of #19264

@chaodaiG
Copy link
Contributor Author

/cc @spiffxp

@k8s-ci-robot k8s-ci-robot requested a review from spiffxp March 30, 2021 16:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2021
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 30, 2021
@chaodaiG chaodaiG mentioned this pull request Mar 30, 2021
Closed
2 tasks
@chaodaiG chaodaiG force-pushed the ownersdir-denylist branch from 0c25b35 to f0cc292 Compare March 31, 2021 14:49
@chaodaiG
Copy link
Contributor Author

chaodaiG commented Apr 2, 2021

/cc @cjwagner

@k8s-ci-robot k8s-ci-robot requested a review from cjwagner April 2, 2021 15:45
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f0df0dd into kubernetes:master Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 6, 2021
@chaodaiG chaodaiG mentioned this pull request Apr 7, 2021
Merged
@chaodaiG chaodaiG deleted the ownersdir-denylist branch April 7, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

@fejta fejta Awaiting requested review from fejta

@michelle192837 michelle192837 Awaiting requested review from michelle192837

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/hook Issues or PRs related to prow's hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@chaodaiG @k8s-ci-robot @petr-muller