Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert revert ownersdir denylist #21693

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Revert revert ownersdir denylist #21693

merged 2 commits into from
Apr 7, 2021

Conversation

chaodaiG
Copy link
Contributor

@chaodaiG chaodaiG commented Apr 7, 2021

Trying again #21577

This PR breaks down to 2 commits:

Related https://kubernetes.slack.com/archives/C7J9RP96G/p1617765164034100

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Apr 7, 2021

/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6f0b9e1 into kubernetes:master Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 7, 2021
@chaodaiG chaodaiG deleted the revert-revert-ownersdir-denylist branch April 7, 2021 16:23
wongma7
wongma7 reviewed Apr 7, 2021
View reviewed changes
prow/repoowners/repoowners.go
@@ -394,7 +394,10 @@ func (c *Client) cacheEntryFor(org, repo, base, cloneRef, fullName, sha string,
log.WithField("duration", time.Since(start).String()).Debugf("Completed loadAliasesFrom(%s, log)", gitRepo.Directory())

start = time.Now()
ignoreDirPatterns := c.ownersDirBlacklist().ListIgnoredDirs(org, repo)
var ignoreDirPatterns []string
if ownersDirDenylist := c.ownersDirDenylist(); ownersDirDenylist != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still broken for me, it looks like this change was deployed in the latest prow image already?

In my PR, the bot is detecting OWNERS files in my vendor dir:
kubernetes-sigs/aws-ebs-csi-driver#792

the type of OwnersDirBlacklist changed from OwnersDirBlacklist to pointer to OwnersDirDenylist.

Previously if ownersDirBlacklist() returned an empty OwnersDirBlacklist struct, then ownersDirBlacklist.ListIgnoredDirs would still add the default ignored dirs.

Now if ownersDirDenylist is nil, the ownersDirBlacklist.ListIgnoredDirs don't get added.

wongma7
wongma7 reviewed Apr 7, 2021
View reviewed changes
Copy link
Contributor

@wongma7 wongma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert, it's still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/hook Issues or PRs related to prow's hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@chaodaiG @k8s-ci-robot @alvaroaleman @wongma7