Bump k8s dependencies to 1.20.4, csi spec to 1.3, external-snapshotter client to v4, go to 1.16

[wongma7]

Is this a bug fix or adding new feature? fixes #723

What is this PR about? / Why do we need it?

commits 1-5: go dependency bumps

commits 6-9: YAML image/API version bumps

commits 10-13: e2e test kops version bumps

What testing is done?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 1808

• 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 81.636%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/driver/controller.go	0	4	0.0%

Totals
Change from base Build 1801:	-0.2%
Covered Lines:	1756
Relevant Lines:	2151

---

💛 - Coveralls

[wongma7]

client api changed, will fix.

../../../../pkg/mod/github.com/kubernetes-csi/external-snapshotter/[email protected]/pkg/client/clientset/versioned/typed/volumesnapshot/v1beta1/volumesnapshot.go:188:5: not enough arguments in call to c.client.Patch(pt).Namespace(c.ns).Resource("volumesnapshots").SubResource(subresources...).Name(name).Body(data).Do
have ()
want (context.Context)
../../../../pkg/mod/github.com/kubernetes-csi/external-snapshotter/[email protected]/pkg/client/clientset/versioned/typed/volumesnapshot/v1beta1/volumesnapshotclass.go:70:5: not enough arguments in call to c.client.Get().Resource("volumesnapshotclasses").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do

[wongma7]

pkg/driver/driver.go:128:33: cannot use d (type *Driver) as type csi.ControllerServer in argument to csi.RegisterControllerServer:
*Driver does not implement csi.ControllerServer (missing ControllerGetVolume method)

I 'm going to leave it unimplemented

[wongma7]

/test pull-aws-ebs-csi-driver-external-test-latest

[wongma7]

The code added in 1.19 for getting metrics from kcm pod doesn't work for us:

Mar 15 16:56:01.625: INFO: ERROR unable to parse requirement: invalid label value: "kube-controller-manager-ip-172-20-39-70.us-west-2.compute.internal": at key: "name": must be no more than 63 characters

[wongma7]

Also, there is no way to disable this metrics grabbing code. We already check KCM metrics ourselves at the end of the test to see if csi or in tree was getting called so it's redundant :/

[wongma7]

hmmm I need to fix my logging code:

Printing pod ebs-csi-controller-77fd584dc8-hkg6k ebs-plugin container logs

Error from server (Forbidden): Forbidden (user=system:anonymous, verb=get, resource=nodes, subresource=proxy) ( pods/log ebs-csi-controller-77fd584dc8-hkg6k)

[wongma7]

actually it's causing test failures as well since some of them check pod logs.

                  s: "error running /usr/local/bin/kubectl --server=https://api-test-cluster-8868-k8s-rjdnu3-1175551248.us-west-2.elb.amazonaws.com --kubeconfig=/root/.kube/config --namespace=volume-3874 exec aws-injector --namespace=volume-3874 -- /bin/sh -c echo 'Hello from aws from namespace volume-3874' > /opt/0/index.html:\nCommand stdout:\n\nstderr:\nerror: unable to upgrade connection: Forbidden (user=system:anonymous, verb=create, resource=nodes, subresource=proxy)\n\nerror:\nexit status 1",
              }, 

[wongma7]

something to do with the blacklist /denylist change. kubernetes/test-infra#21687

[wongma7]

TooManyLoadBalancers

[wongma7]

/retest

[wongma7]

/verify-owners

[wongma7]

/verify-owners

[ayberk]

Hmm this is kind of dangerous. What if we start building alpha images?

[wongma7]

people should be using the stable overlay. However I agree best not to even mention latest tag, I'l lcheck where it's coming from (like is it being propagated from a helm chart?)

[k8s-ci-robot]

@wongma7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

replaced by #828