Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WG Naming] Make recommendation for allowlist/denylist #5341

Merged

Conversation

celestehorgan
Copy link
Contributor

Signed-off-by: Celeste Horgan [email protected]

This PR adds a recommendation to remove blacklist/whitelist from codebases and replace with allowlist/denylist.

Unblocks the following issues by adding a formal recommendation (i.e, work can be done):

kubernetes/test-infra#19264
kubernetes/kubernetes#90277

/assign @justaugustus @zacharysarah @jdumars

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/naming Categorizes an issue or PR as relevant to WG Naming. labels Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020

* [“Blacklists” and “whitelists”: a salutary warning concerning the prevalence of racist language in discussions of predatory publishing](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6148600/)

* [IETF Network Working Group: Terminology, Power and Oppressive Language](https://tools.ietf.org/id/draft-knodel-terminology-00.html)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a concern, but the Internet-Drafts are something that we should not use for ref. The definition from ietf states as quoted below. Please see the link here

Internet-Drafts have no formal status, and are subject to change or removal at any time; therefore they should not be cited or quoted in any formal document. 

Copy link

@gkarthiks gkarthiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question is, how do we deal with the archived repo or docs. I encountered one today here in this repo k/community and it states as

The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.

Should that also considered for changes?

Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@celestehorgan Nice. 👍 Some grammar nits/typos, otherwise LGTM.

@celestehorgan
Copy link
Contributor Author

FYI: returning to this today.

@celestehorgan
Copy link
Contributor Author

One more question is, how do we deal with the archived repo or docs. I encountered one today here in this repo k/community and it states as

The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.

Should that also considered for changes?

I think the strategy here is to leave archived repos as-is. I'll add this to the agenda for today's meeting though.

@celestehorgan celestehorgan force-pushed the adr-allowlist-denylist branch from a89e9ba to ec8ca58 Compare January 11, 2021 16:53
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 11, 2021
@jdumars
Copy link
Member

jdumars commented Jan 11, 2021

/lgtm
/hold
unhold once the checks are resolved

Thank you Celeste for this work!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@justaugustus
Copy link
Member

/check-cla
/verify-owners

@celestehorgan
Copy link
Contributor Author

@justaugustus it's because I'm on a new computer, my commits aren't signing correctly D:

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021
@celestehorgan celestehorgan force-pushed the adr-allowlist-denylist branch from 2d546e6 to cf744dc Compare January 12, 2021 00:28
Signed-off-by: Celeste Horgan <[email protected]>

Apply suggestions from code review

Co-authored-by: Zach Corleissen <[email protected]>
Co-authored-by: Joyce Kung <[email protected]>
Add remaining suggestions
@celestehorgan celestehorgan force-pushed the adr-allowlist-denylist branch from cf744dc to 2c142c6 Compare January 12, 2021 00:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2021
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan, jdumars, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@celestehorgan
Copy link
Contributor Author

/hold remove

@zacharysarah
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5fb733c into kubernetes:master Jan 12, 2021
@justaugustus
Copy link
Member

Go team! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants