-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WG Naming] Make recommendation for allowlist/denylist #5341
[WG Naming] Make recommendation for allowlist/denylist #5341
Conversation
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
|
||
* [“Blacklists” and “whitelists”: a salutary warning concerning the prevalence of racist language in discussions of predatory publishing](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6148600/) | ||
|
||
* [IETF Network Working Group: Terminology, Power and Oppressive Language](https://tools.ietf.org/id/draft-knodel-terminology-00.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a concern, but the Internet-Drafts
are something that we should not use for ref. The definition from ietf states as quoted below. Please see the link here
Internet-Drafts have no formal status, and are subject to change or removal at any time; therefore they should not be cited or quoted in any formal document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question is, how do we deal with the archived repo or docs. I encountered one today here in this repo k/community and it states as
The Design Proposal process has been deprecated in favor of Kubernetes Enhancement Proposals (KEP). These documents are here for historical purposes only.
Should that also considered for changes?
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@celestehorgan Nice. 👍 Some grammar nits/typos, otherwise LGTM.
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
wg-naming/recommendations/002-blacklist-whitelist-allowlist-denylist.md
Outdated
Show resolved
Hide resolved
FYI: returning to this today. |
I think the strategy here is to leave archived repos as-is. I'll add this to the agenda for today's meeting though. |
a89e9ba
to
ec8ca58
Compare
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm Thank you Celeste for this work! |
/check-cla |
@justaugustus it's because I'm on a new computer, my commits aren't signing correctly D: |
2d546e6
to
cf744dc
Compare
Signed-off-by: Celeste Horgan <[email protected]> Apply suggestions from code review Co-authored-by: Zach Corleissen <[email protected]> Co-authored-by: Joyce Kung <[email protected]> Add remaining suggestions
cf744dc
to
2c142c6
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celestehorgan, jdumars, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold remove |
/hold cancel |
Go team! ❤️ |
Signed-off-by: Celeste Horgan [email protected]
This PR adds a recommendation to remove blacklist/whitelist from codebases and replace with allowlist/denylist.
Unblocks the following issues by adding a formal recommendation (i.e, work can be done):
kubernetes/test-infra#19264
kubernetes/kubernetes#90277
/assign @justaugustus @zacharysarah @jdumars