Transition from SPDY to WebSockets #4006
Assignees
Labels
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
stage/beta
Denotes an issue tracking an enhancement targeted for Beta status
tracked/yes
Denotes an enhancement issue is actively being tracked by the Release Team
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Milestone
Comments
k8s-ci-robot
added
the
needs-sig
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
|
/sig cli |
k8s-ci-robot
added
stage/alpha
This was referenced May 17, 2023
|
/milestone v1.28 |
k8s-ci-robot
added
the
lead-opted-in
|
Hello @seans3 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
|
Hello. Since the PRR reviewer @deads2k approved the KEP and since the KEP has been merged, I believe this KEP is now ready for v1.28. Please let me know if there are any other tasks needed for this release. Thanks. |
|
Hello @seans3! 1.28 Docs Shadow here. Does this enhancement work planned for 1.28 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
This was referenced Jul 1, 2023
|
Hey @seans3 , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023. |
|
Hey again @seans3 👋 I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above. As always, we are here to help if any questions come up. Thanks! |
|
Hello @seans3 👋, 1.28 Enhancements Lead here. Unfortunately, the implementation (code related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone. If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks! /milestone clear |
Atharva-Shinde
moved this from Tracked
to Removed from Milestone
in 1.28 Enhancements Tracking
3 tasks
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 26, 2024
…r WebSocket protocol Kubernetes currently supports two streaming protocols- SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006 Our 'kubectl exec' session recording was only supporting SPDY. This change: - adds functionality to parse streaming sessions over WebSockets - for sessions that the API server proxy has determined need to be recorded, determines if the session is over SPDY or WebSockets and invoke the relevant parser accordingly - refactors the session recording logic into its own package Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 29, 2024
…Sockets sessions Kubernetes currently supports two streaming protocols, SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006. We were currently only supporting SPDY, erroring out if session was not SPDY and relying on the kube's built-in SPDY fallback. This PR: - adds support for parsing contents of 'kubectl exec' sessions streamed over WebSockets - adds logic to distinguish 'kubectl exec' requests for a SPDY/WebSockets sessions and call the relevant handler Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 29, 2024
…Sockets sessions Kubernetes currently supports two streaming protocols, SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006. We were currently only supporting SPDY, erroring out if session was not SPDY and relying on the kube's built-in SPDY fallback. This PR: - adds support for parsing contents of 'kubectl exec' sessions streamed over WebSockets - adds logic to distinguish 'kubectl exec' requests for a SPDY/WebSockets sessions and call the relevant handler Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Jul 29, 2024
…Sockets sessions Kubernetes currently supports two streaming protocols, SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006. We were currently only supporting SPDY, erroring out if session was not SPDY and relying on the kube's built-in SPDY fallback. This PR: - adds support for parsing contents of 'kubectl exec' sessions streamed over WebSockets - adds logic to distinguish 'kubectl exec' requests for a SPDY/WebSockets sessions and call the relevant handler Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]>
Princesso
moved this from Tracked for Code Freeze
to Tracked for Doc Freeze
in 1.31 Enhancements Tracking
irbekrm
added a commit
to tailscale/tailscale
that referenced
this issue
Aug 14, 2024
…ectl exec sessions over WebSockets (#12947) cmd/k8s-operator,k8s-operator/sessionrecording: support recording WebSocket sessions Kubernetes currently supports two streaming protocols, SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006. We were currently only supporting SPDY, erroring out if session was not SPDY and relying on the kube's built-in SPDY fallback. This PR: - adds support for parsing contents of 'kubectl exec' sessions streamed over WebSockets - adds logic to distinguish 'kubectl exec' requests for a SPDY/WebSockets sessions and call the relevant handler Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]> Co-authored-by: Tom Proctor <[email protected]>
Asutorufa
pushed a commit
to Asutorufa/tailscale
that referenced
this issue
Aug 23, 2024
…ectl exec sessions over WebSockets (tailscale#12947) cmd/k8s-operator,k8s-operator/sessionrecording: support recording WebSocket sessions Kubernetes currently supports two streaming protocols, SPDY and WebSockets. WebSockets are replacing SPDY, see kubernetes/enhancements#4006. We were currently only supporting SPDY, erroring out if session was not SPDY and relying on the kube's built-in SPDY fallback. This PR: - adds support for parsing contents of 'kubectl exec' sessions streamed over WebSockets - adds logic to distinguish 'kubectl exec' requests for a SPDY/WebSockets sessions and call the relevant handler Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <[email protected]> Co-authored-by: Tom Proctor <[email protected]>
|
Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32. /remove-label lead-opted-in |
k8s-ci-robot
removed
the
lead-opted-in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Enhancement Description
One-line enhancement description (can be used as a release note): Transition the bi-directional streaming protocol of Kubernetes clients from SPDY/3.1 to WebSockets.
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4006-transition-spdy-to-websockets
Discussion Link:
Primary contact (assignee): @seans3
Responsible SIGs: SIG API Machinery, SIG CLI
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements) update PR(s):k/k) update PR(s):k/website) update PR(s):Beta
k/enhancements) update PR(s):k/k) update PR(s):k/website) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: