-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-4006] Docs for Transitioning from SPDY to WebSockets (Beta) #45270
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
295fc9a
to
d73e555
Compare
d73e555
to
d31c191
Compare
d31c191
to
936b372
Compare
/cc @fsmunoz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seans3 We should consider setting the dev-1.30
branch as the target branch rather than the main
branch for this pull request. Since the change is related to the feature in v1.30
.
936b372
to
2c8bbd2
Compare
Fixed. Please let me know if this does it. Thanks. |
Thank you @seans3, looks good, I've updated the tracking sheet. |
Hey @seans3! Just a reminder that this needs to be reviewed and ready to merge by Docs Freeze on March 26, including a technical review. An exception request will be required if you cannot meet that deadline. Thank you! |
/lgtm |
LGTM label has been added. Git tree hash: f56d8fd401b9c8ad4031fea77a7187d0d732126d
|
@kubernetes/sig-docs-en-reviews Can we get a review of the content from docs on this one? The deadline is March 26th 2024 18:00 PT to get this into the release. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
<td colspan="2">KUBECTL_PORT_FORWARD_WEBSOCKETS</td> | ||
</tr> | ||
<tr> | ||
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, the kubectl port-forward command will attempt to stream using the websockets protocol. If the upgrade to websockets fails, the commands will fallback to use the current SPDY protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, the kubectl port-forward command will attempt to stream using the websockets protocol. If the upgrade to websockets fails, the commands will fallback to use the current SPDY protocol. | |
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, the <tt>kubectl port-forward</tt> command attempts to stream using a <a href="https://www.w3.org/TR/websockets/">WebSocket</a>. If the upgrade to using a WebSocket fails, the kubectl tool falls back to using the <a href="https://www.chromium.org/spdy/">SPDY</a> protocol. |
The suggested text avoids implying that SPDY is “current”. However, if this is different from the text already in k/k code, we should use that text from upstream as-is.
(it'd be great to get good docs into kubectl
itself, where relevant)
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 1.30 |
TranslateStreamCloseWebsocketRequests
to BetaPortForwardWebsockets
as Alphakubectl
feature flag:KUBECTL_PORT_FORWARD_WEBSOCKETS
kubernetes/enhancements#4006