Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006) #43620

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006) #43620

merged 1 commit into from
Nov 18, 2023

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Oct 20, 2023 •
edited
Loading

  • Adds documentation for new alpha TranslateStreamCloseWebsocketRequests feature flag, allowing the control plane to accept WebSockets/V5 upgrade requests.
  • Adds documentation for new alpha kubectl environment variable KUBECTL_REMOTE_COMMAND_WEBSOCKETS feature flag, which attempts to use the WebSockets protocol for kubectl exec, kubectl cp, and kubectl attach when it is set.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2023
@seans3
Copy link
Contributor Author

seans3 commented Oct 20, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b8cd2f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6553bd66678f6d00088aad09
😎 Deploy Preview https://deploy-preview-43620--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seans3 seans3 mentioned this pull request Oct 20, 2023
Open
8 tasks
@sftim
Copy link
Contributor

sftim commented Oct 23, 2023

/retitle [WIP] Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006)

@k8s-ci-robot k8s-ci-robot changed the title KEP-4006: Transition from SPDY to WebSockets -- Alpha Docs [WIP] Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006) Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@taniaduggal
Copy link
Contributor

Hello @seans3 👋, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@seans3 seans3 changed the title [WIP] Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006) Document Kubernetes' use of WebSockets (replacement for SPDY / KEP 4006) Nov 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@liggitt
Copy link
Member

liggitt commented Nov 14, 2023

retarget this against the dev-1.29 branch, lgtm otherwise

@liggitt
Copy link
Member

liggitt commented Nov 14, 2023

/assign

@seans3 seans3 changed the base branch from main to dev-1.29 November 14, 2023 18:35
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 407407e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6553ca5edb9fd60008b39381

@k8s-ci-robot k8s-ci-robot added language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language labels Nov 14, 2023
@seans3 seans3 force-pushed the kep-4006-docs branch 2 times, most recently from de679c6 to 4efb315 Compare November 14, 2023 19:24
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2023
@sftim
Copy link
Contributor

sftim commented Nov 14, 2023

/remove-language de
/remove-language es
/remove-language fr
/remove-language id
/remove-language ru
/remove-language uk
/remove-language vi
/remove-language zh

/remove-area blog

@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language area/blog Issues or PRs related to the Kubernetes Blog subproject labels Nov 14, 2023
@seans3
Copy link
Contributor Author

seans3 commented Nov 14, 2023

/remove-language it

@k8s-ci-robot k8s-ci-robot removed the language/it Issues or PRs related to Italian language label Nov 14, 2023
@liggitt
Copy link
Member

liggitt commented Nov 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b02e076b851de706b0ca856c107e710a05f13101

@tengqm
Copy link
Contributor

tengqm commented Nov 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit b8b45ee into kubernetes:dev-1.29 Nov 18, 2023
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@seans3 @sftim @taniaduggal @liggitt @k8s-ci-robot @tengqm