Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4006: Adds GA requirement for websocket HTTPS proxy support #4777

Merged
merged 1 commit into from
Aug 26, 2024
Merged

KEP-4006: Adds GA requirement for websocket HTTPS proxy support #4777

merged 1 commit into from
Aug 26, 2024

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jul 30, 2024 •
edited
Loading

#4006

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and sttts July 30, 2024 17:02
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2024

/assign @liggitt
/assign @aojea

@liggitt
Copy link
Member

liggitt commented Jul 30, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
jpbetz
jpbetz reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Makes perfect sense to me.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@aojea
Copy link
Member

aojea commented Aug 26, 2024

/lgtm
/approve

missed it, redundant but just to ack

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, jpbetz, liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62cad7d into kubernetes:master Aug 26, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@seans3 @liggitt @aojea @k8s-ci-robot @jpbetz