Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4006: PortForward Websockets graduates to Beta #4666

Merged
merged 1 commit into from
Jun 10, 2024
Merged

KEP-4006: PortForward Websockets graduates to Beta #4666

merged 1 commit into from
Jun 10, 2024

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented May 28, 2024

  • PortForward Websocket graduates to Beta in KEP.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from apelisse May 28, 2024 03:37
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz May 28, 2024 03:37
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2024
@seans3
Copy link
Contributor Author

seans3 commented May 28, 2024

/assign @aojea
/assign @liggitt

@seans3
Copy link
Contributor Author

seans3 commented May 28, 2024

/uncc @apelisse

@k8s-ci-robot k8s-ci-robot removed the request for review from apelisse May 28, 2024 03:38
@seans3 seans3 mentioned this pull request May 28, 2024
Open
8 tasks
seans3
seans3 commented May 28, 2024
View reviewed changes
keps/sig-api-machinery/4006-transition-spdy-to-websockets/README.md
@@ -317,22 +317,6 @@ is redirected to other API endpoints.

- Mitigation: Upgraded connections are disallowed from redirecting.

- Risk: Overloaded Concurrency
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, since this risk was associated with StreamTranslation, and it was fixed when the design was updated to StreamTunneling.

@seans3 seans3 force-pushed the portforward-websockets-beta branch from b780586 to a4a8c0c Compare May 28, 2024 03:45
@jpbetz
Copy link
Contributor

jpbetz commented May 28, 2024

I'm okay with PortForward over WebSockets shipped as beta in v1.31. The rest of this looks like retroactive updates to reflect the tunneling decision made in 1.30.

Any concerns @deads2k ?

@liggitt
Copy link
Member

liggitt commented May 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jun 7, 2024

/cc @deads2k

@k8s-ci-robot k8s-ci-robot requested a review from deads2k June 7, 2024 20:36
@deads2k
Copy link
Contributor

deads2k commented Jun 10, 2024

I'm okay with PortForward over WebSockets shipped as beta in v1.31. The rest of this looks like retroactive updates to reflect the tunneling decision made in 1.30.

Any concerns @deads2k ?

lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit fef4a92 into kubernetes:master Jun 10, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@seans3 @jpbetz @liggitt @deads2k @k8s-ci-robot @aojea