Fixes for Hetzner terraform and Hetzner Cloud #8702

Anthony-Bible · 2022-04-10T18:15:48Z

What type of PR is this?

/kind bug

What this PR does / why we need it:
This makes various enhancements and bug fixes to Hetzner items

Defines a configurable variable for network_zone in terraform
Define a variable with_networks to differentiate deployments of hcloud cloud controller with networks support
Exports created network id from Hetzner terraform to inventory.ini
Various templating fixes for the Hetzner external cloud controller
Which issue(s) this PR fixes:

Special notes for your reviewer:
I originally started working on these changes to fix the ability of specifying the network_zone but found some more fixes needed along the way. If needed, I can separate these two changes into two separate PRs (terraform and ansible changes)
Does this PR introduce a user-facing change?:

Add `with_networks` variable to `external_hcloud_cloud` in ansible playbook and `network_zone` variable to Hetzner Cloud Terraform.

- Export the network id from hetzner terraform the the generated inventory.ini

… controller manager - Add network id to hcloud controller secret (added via the inventory) - Don't include extra_args if it's not set

linux-foundation-easycla · 2022-04-10T18:15:50Z

The committers listed above are authorized under a signed CLA.

✅ login: Anthony-Bible / name: Anthony Bible (992ab33, f1e87fe)

k8s-ci-robot · 2022-04-10T18:15:55Z

Welcome @Anthony-Bible!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-04-10T18:15:56Z

Hi @Anthony-Bible. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Anthony-Bible · 2022-04-10T18:23:46Z

/check-cla

Anthony-Bible · 2022-04-10T18:34:13Z

/unassign @mattymo

Sorry was a bit hasty and missed the part where it said to do it after approval

floryut

/ok-to-test
@Anthony-Bible Love the "DeamonSet" part 😅

k8s-ci-robot · 2022-04-11T08:20:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Anthony-Bible, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

WebSpider · 2022-04-11T14:03:56Z

Oooh that explains why the components weren't there .. 🙈

cristicalin · 2022-04-11T17:25:06Z

...xternal_cloud_controller/hcloud/templates/external-hcloud-cloud-controller-manager-ds.yml.j2

@@ -1,6 +1,6 @@
 ---
 apiVersion: apps/v1
-kind: DeamonSet


This is the kind of issue for which we should have molecule testing doing kubectl apply --dry-run --client-only to test our rendered code is at least a valid kubernetes manifest.

cristicalin · 2022-04-11T17:25:45Z

Thanks @Anthony-Bible for doing this!

/lgtm

* master: (21 commits) Add tz to kubespray image Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705) Enable external CA mode for control-plane deployment (kubernetes-sigs#8620) UpCloud integration (kubernetes-sigs#8653) Fixes for Hetzner terraform and Hetzner Cloud (kubernetes-sigs#8702) Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697) Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695) [calico] add calico apiserver (kubernetes-sigs#8690) Add support for kube-vip (kubernetes-sigs#8669) Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692) [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688) fix: reset docker was not removing docker properly (kubernetes-sigs#8680) Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683) split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677) [crun] upgrade to 1.4.4 (kubernetes-sigs#8675) [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679) [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671) [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676) [runc] upgrade to 1.1.1 (kubernetes-sigs#8674) [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672) ...

* - add ability to specify the network_zone in hetzner terraform - Export the network id from hetzner terraform the the generated inventory.ini * - Add with_networks variable to allow different deployments of hcloud controller manager - Add network id to hcloud controller secret (added via the inventory) - Don't include extra_args if it's not set

Anthony-Bible added 2 commits April 10, 2022 11:44

- add ability to specify the network_zone in hetzner terraform

992ab33

- Export the network id from hetzner terraform the the generated inventory.ini

- Add with_networks variable to allow different deployments of hcloud…

f1e87fe

… controller manager - Add network id to hcloud controller secret (added via the inventory) - Don't include extra_args if it's not set

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2022

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 10, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2022

k8s-ci-robot requested review from cristicalin and jayonlau April 10, 2022 18:16

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 10, 2022

k8s-ci-robot assigned mattymo Apr 10, 2022

k8s-ci-robot unassigned mattymo Apr 10, 2022

floryut approved these changes Apr 11, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022

cristicalin reviewed Apr 11, 2022

View reviewed changes

k8s-ci-robot assigned cristicalin Apr 11, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2022

k8s-ci-robot merged commit 9dced71 into kubernetes-sigs:master Apr 11, 2022

oomichi mentioned this pull request May 28, 2022

Release Proposal v2.19 #8885

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for Hetzner terraform and Hetzner Cloud #8702

Fixes for Hetzner terraform and Hetzner Cloud #8702

Anthony-Bible commented Apr 10, 2022 •

edited by floryut

Loading

linux-foundation-easycla bot commented Apr 10, 2022 •

edited

Loading

k8s-ci-robot commented Apr 10, 2022

k8s-ci-robot commented Apr 10, 2022

Anthony-Bible commented Apr 10, 2022

Anthony-Bible commented Apr 10, 2022 •

edited

Loading

floryut left a comment

k8s-ci-robot commented Apr 11, 2022

WebSpider commented Apr 11, 2022

cristicalin Apr 11, 2022

cristicalin commented Apr 11, 2022

Fixes for Hetzner terraform and Hetzner Cloud #8702

Fixes for Hetzner terraform and Hetzner Cloud #8702

Conversation

Anthony-Bible commented Apr 10, 2022 • edited by floryut Loading

linux-foundation-easycla bot commented Apr 10, 2022 • edited Loading

k8s-ci-robot commented Apr 10, 2022

k8s-ci-robot commented Apr 10, 2022

Anthony-Bible commented Apr 10, 2022

Anthony-Bible commented Apr 10, 2022 • edited Loading

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 11, 2022

WebSpider commented Apr 11, 2022

cristicalin Apr 11, 2022

Choose a reason for hiding this comment

cristicalin commented Apr 11, 2022

Anthony-Bible commented Apr 10, 2022 •

edited by floryut

Loading

linux-foundation-easycla bot commented Apr 10, 2022 •

edited

Loading

Anthony-Bible commented Apr 10, 2022 •

edited

Loading