Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calico] add calico apiserver #8690

Merged
merged 5 commits into from
Apr 8, 2022
Merged

[calico] add calico apiserver #8690

merged 5 commits into from
Apr 8, 2022

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented Apr 6, 2022 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature
we can enable the calico api server.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #8502

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[calico] Add calico apiserver (using `calico_apiserver_enabled` variable)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 6, 2022
@k8s-ci-robot k8s-ci-robot requested review from jayonlau and oomichi April 6, 2022 10:25
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2022
@cristicalin
Copy link
Contributor

Awesome work @liupeng0518 !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, liupeng0518

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@cristicalin
Copy link
Contributor

@liupeng0518 seems like the CI uncovered an issue:

fatal: [instance-1]: FAILED! => {"changed": true, "cmd": ["/usr/local/bin/make-ssl-apiserver.sh", "-f", "/etc/calico/certs/openssl.conf", "-c", "/etc/kubernetes/ssl", "-d", "/etc/calico/certs", "-s", "apiserver"], "delta": "0:00:00.549125", "end": "2022-04-06 17:52:56.868123", "msg": "non-zero return code", "rc": 1, "start": "2022-04-06 17:52:56.318998", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

@floryut floryut added kind/network Network section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Apr 7, 2022
@liupeng0518
Copy link
Member Author

liupeng0518 commented Apr 7, 2022 •
edited
Loading

@liupeng0518 seems like the CI uncovered an issue:

fatal: [instance-1]: FAILED! => {"changed": true, "cmd": ["/usr/local/bin/make-ssl-apiserver.sh", "-f", "/etc/calico/certs/openssl.conf", "-c", "/etc/kubernetes/ssl", "-d", "/etc/calico/certs", "-s", "apiserver"], "delta": "0:00:00.549125", "end": "2022-04-06 17:52:56.868123", "msg": "non-zero return code", "rc": 1, "start": "2022-04-06 17:52:56.318998", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

Done, centos 7 openssl too old.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2022
oomichi
oomichi reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one comment.

/cc @oomichi

roles/network_plugin/calico/defaults/main.yml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi April 7, 2022 17:32
@oomichi
Copy link
Contributor

oomichi commented Apr 8, 2022

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 424ef3b into kubernetes-sigs:master Apr 8, 2022
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 14, 2022
Merge branch 'master' into feature/virtualbox
da2c785 
* master: (21 commits)
  Add tz to kubespray image
  Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705)
  Enable external CA mode for control-plane deployment (kubernetes-sigs#8620)
  UpCloud integration (kubernetes-sigs#8653)
  Fixes for Hetzner terraform and Hetzner Cloud  (kubernetes-sigs#8702)
  Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697)
  Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
  [calico] add calico apiserver (kubernetes-sigs#8690)
  Add support for kube-vip (kubernetes-sigs#8669)
  Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692)
  [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688)
  fix: reset docker was not removing docker properly (kubernetes-sigs#8680)
  Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683)
  split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677)
  [crun] upgrade to 1.4.4 (kubernetes-sigs#8675)
  [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679)
  [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671)
  [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676)
  [runc] upgrade to 1.1.1 (kubernetes-sigs#8674)
  [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672)
  ...
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@liupeng0518 @sakuraiyuta
[calico] add calico apiserver (kubernetes-sigs#8690)
3c04e03 
* [calico] add calico apiserver

* fix yamllint

* remove addext argument

* Configure API server with the CA bundle

* add check kdd
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@liupeng0518 @LuckySB
[calico] add calico apiserver (kubernetes-sigs#8690)
3c4eefa 
* [calico] add calico apiserver

* fix yamllint

* remove addext argument

* Configure API server with the CA bundle

* add check kdd
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@liupeng0518 @LuckySB
[calico] add calico apiserver (kubernetes-sigs#8690)
d3da61d 
* [calico] add calico apiserver

* fix yamllint

* remove addext argument

* Configure API server with the CA bundle

* add check kdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@jayonlau jayonlau Awaiting requested review from jayonlau

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add calico api server
5 participants
@liupeng0518 @cristicalin @k8s-ci-robot @oomichi @floryut