split kube_feature_gates variable for different kubernetes components #8677

alegrey91 · 2022-04-03T12:51:11Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Not all the components need the same configuration and we would configure them as best as possible.
An example could be the recently added feature for the kubelet component: KubeletInUserNamespace. This is not suitable for all the components, so we would use it just for kubelet.

Which issue(s) this PR fixes:

Fixes #8666

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Split kube_feature_gates variable for different kubernetes components (/!\ ⚠️ ADD NOTE : This add some variables that could be defined by the user. It doesn't introduce a breaking change because the previous unique variable (kube_feature_gates) still works as expected.  kube_apiserver_feature_gates/kube_controller_feature_gates/kube_scheduler_feature_gates/kube_proxy_feature_gates/kubelet_feature_gates)

linux-foundation-easycla · 2022-04-03T12:51:14Z

The committers listed above are authorized under a signed CLA.

✅ login: alegrey91 / name: Alessio Greggi (5ff2883, fab4696)

k8s-ci-robot · 2022-04-03T12:51:19Z

Welcome @alegrey91!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-04-03T12:51:19Z

Hi @alegrey91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cristicalin · 2022-04-03T13:02:27Z

Nice work @alegrey91 !

I think you can avoid a bit of verbosity with the suggestion above in a few places.

/ok-to-test

alegrey91 · 2022-04-03T13:09:07Z

Hi @cristicalin, thanks a lot.
Do you mean in the documentation side?

cristicalin · 2022-04-03T15:03:14Z

Do you mean in the documentation side?

In the actual code, sorry, Github batch review defeated me today, I added a review to a batch and forgot to push it.

cristicalin · 2022-04-03T13:00:20Z

roles/kubernetes/control-plane/templates/kubeadm-config.v1beta2.yaml.j2

@@ -196,8 +196,11 @@ apiServer:
 {% for key in kube_kubeadm_apiserver_extra_args %}
    {{ key }}: "{{ kube_kubeadm_apiserver_extra_args[key] }}"
 {% endfor %}
-{% if kube_feature_gates %}
+{% if kube_apiserver_feature_gates is defined %}


you could write this as

Suggested change

{% if kube_apiserver_feature_gates is defined %}

{% kube_apiserver_feature_gates | default(kube_feature_gates)) | join(',') %}

Hi @cristicalin, thanks for your suggestion :)
I checked the code, but something was wrong.
What do you think to use this instead?

{% if kube_apiserver_feature_gates or kube_feature_gates %} feature-gates: "{{ kube_apiserver_feature_gates | default(kube_feature_gates) | join(',') }}" {% endif %}

Putting the kube_apiserver_feature_gates variable into defaults/main.yaml.

Done! Let me know if the implementation is fine ;)

cristicalin · 2022-04-04T18:02:40Z

The molecule failure seems like a vagrant cloud issue, if you push a change it should re-trigger that test and hopefully succeed.

…onents

cristicalin · 2022-04-05T12:31:26Z

Vagrant job failures are related to an earlier issue that should not affect this change.
Thanks @alegrey91 !

/lgtm

floryut

@alegrey91 Nice work 👍

k8s-ci-robot · 2022-04-05T12:36:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegrey91, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* master: (21 commits) Add tz to kubespray image Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705) Enable external CA mode for control-plane deployment (kubernetes-sigs#8620) UpCloud integration (kubernetes-sigs#8653) Fixes for Hetzner terraform and Hetzner Cloud (kubernetes-sigs#8702) Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697) Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695) [calico] add calico apiserver (kubernetes-sigs#8690) Add support for kube-vip (kubernetes-sigs#8669) Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692) [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688) fix: reset docker was not removing docker properly (kubernetes-sigs#8680) Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683) split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677) [crun] upgrade to 1.4.4 (kubernetes-sigs#8675) [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679) [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671) [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676) [runc] upgrade to 1.1.1 (kubernetes-sigs#8674) [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672) ...

…kubernetes-sigs#8677) * feat: split kube_feature_gates variable for different kubernetes components * docs: add kube_feaute_gates componet variables

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 3, 2022

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 3, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2022

k8s-ci-robot requested review from EppO and jayonlau April 3, 2022 12:51

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 3, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2022

cristicalin reviewed Apr 3, 2022

View reviewed changes

alegrey91 added 2 commits April 5, 2022 00:05

feat: split kube_feature_gates variable for different kubernetes comp…

d610672

…onents

docs: add kube_feaute_gates componet variables

4733c48

alegrey91 requested a review from cristicalin April 5, 2022 07:16

k8s-ci-robot assigned cristicalin Apr 5, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2022

floryut approved these changes Apr 5, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022

k8s-ci-robot merged commit bba91a7 into kubernetes-sigs:master Apr 5, 2022

alegrey91 mentioned this pull request May 3, 2022

CIS Benchmark kubespray coverage #8773

Closed

4 tasks

oomichi mentioned this pull request May 28, 2022

Release Proposal v2.19 #8885

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

split kube_feature_gates variable for different kubernetes components #8677

split kube_feature_gates variable for different kubernetes components #8677

alegrey91 commented Apr 3, 2022 •

edited by floryut

Loading

linux-foundation-easycla bot commented Apr 3, 2022 •

edited

Loading

k8s-ci-robot commented Apr 3, 2022

k8s-ci-robot commented Apr 3, 2022

cristicalin commented Apr 3, 2022

alegrey91 commented Apr 3, 2022 •

edited

Loading

cristicalin commented Apr 3, 2022 •

edited

Loading

cristicalin Apr 3, 2022

alegrey91 Apr 4, 2022 •

edited

Loading

cristicalin Apr 4, 2022

alegrey91 Apr 4, 2022

cristicalin commented Apr 4, 2022

cristicalin commented Apr 5, 2022

floryut left a comment

k8s-ci-robot commented Apr 5, 2022

	{% if kube_apiserver_feature_gates is defined %}
	{% kube_apiserver_feature_gates \| default(kube_feature_gates)) \| join(',') %}

split kube_feature_gates variable for different kubernetes components #8677

split kube_feature_gates variable for different kubernetes components #8677

Conversation

alegrey91 commented Apr 3, 2022 • edited by floryut Loading

linux-foundation-easycla bot commented Apr 3, 2022 • edited Loading

k8s-ci-robot commented Apr 3, 2022

k8s-ci-robot commented Apr 3, 2022

cristicalin commented Apr 3, 2022

alegrey91 commented Apr 3, 2022 • edited Loading

cristicalin commented Apr 3, 2022 • edited Loading

cristicalin Apr 3, 2022

Choose a reason for hiding this comment

alegrey91 Apr 4, 2022 • edited Loading

Choose a reason for hiding this comment

cristicalin Apr 4, 2022

Choose a reason for hiding this comment

alegrey91 Apr 4, 2022

Choose a reason for hiding this comment

cristicalin commented Apr 4, 2022

cristicalin commented Apr 5, 2022

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 5, 2022

alegrey91 commented Apr 3, 2022 •

edited by floryut

Loading

linux-foundation-easycla bot commented Apr 3, 2022 •

edited

Loading

alegrey91 commented Apr 3, 2022 •

edited

Loading

cristicalin commented Apr 3, 2022 •

edited

Loading

alegrey91 Apr 4, 2022 •

edited

Loading