Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpCloud integration #8653

Merged
merged 2 commits into from
Apr 11, 2022
Merged

UpCloud integration #8653

merged 2 commits into from
Apr 11, 2022

Conversation

robinAwallace
Copy link
Contributor

@robinAwallace robinAwallace commented Mar 25, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. Add UpClouds new csi-driver
  2. Add the option to use ansible_host as ip in localhost kubeconfig

Which issue(s) this PR fixes:

Special notes for your reviewer:

UpClouds csi-driver is still in alpha and I will try to keep it up to date when they update it.

Does this PR introduce a user-facing change?:

Add the possibility to use UpCloud csi-driver
Add the possibility to use ansbile_host as api ip for localhost kubeconfig

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @robinAwallace. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2022
OlleLarsson
OlleLarsson approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@OlleLarsson OlleLarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just missing the option to set tolerations on the node plugin ds

@llarsson
Copy link
Contributor

/assign @oomichi

Xartos
Xartos reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Xartos Xartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small suggestion

roles/kubernetes-apps/persistent_volumes/upcloud-csi/templates/upcloud-csi-storage-class.yml.j2 Outdated Show resolved Hide resolved
oomichi
oomichi reviewed Mar 26, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes/client/tasks/main.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi March 26, 2022 00:31
@robinAwallace robinAwallace force-pushed the rw/upcloud-intergration branch from b4d6d77 to 117d7d0 Compare April 5, 2022 07:07
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2022
@robinAwallace robinAwallace force-pushed the rw/upcloud-intergration branch 2 times, most recently from c05ae0b to aa87cfc Compare April 5, 2022 10:58
@robinAwallace
Copy link
Contributor Author

@oomichi i have sorted out the comments and updated the chart with volume expansion.

@oomichi
Copy link
Contributor

oomichi commented Apr 6, 2022

Thanks for updating @robinAwallace
The change itself seems good for me.
Now tox-inventory-builder is failed but that is not related to this change because it is failed to install a stable ansible.
Let's re-run the test again later.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlleLarsson, oomichi, robinAwallace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@oomichi
Copy link
Contributor

oomichi commented Apr 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2022
@cristicalin
Copy link
Contributor

@robinAwallace nice work!
To fix the failing CI job you would need to rebase your PR on the state of the latest master branch.

@robinAwallace robinAwallace force-pushed the rw/upcloud-intergration branch 2 times, most recently from aa87cfc to 52164bf Compare April 7, 2022 12:20
@robinAwallace robinAwallace force-pushed the rw/upcloud-intergration branch from 52164bf to c4c6086 Compare April 7, 2022 13:48
@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit d7254ee into kubernetes-sigs:master Apr 11, 2022
Quehenr pushed a commit to Quehenr/unstable-laboratory-infrastructure-kubespray that referenced this pull request Apr 14, 2022
Merge branch 'master' into feature/virtualbox
da2c785 
* master: (21 commits)
  Add tz to kubespray image
  Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705)
  Enable external CA mode for control-plane deployment (kubernetes-sigs#8620)
  UpCloud integration (kubernetes-sigs#8653)
  Fixes for Hetzner terraform and Hetzner Cloud  (kubernetes-sigs#8702)
  Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697)
  Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695)
  [calico] add calico apiserver (kubernetes-sigs#8690)
  Add support for kube-vip (kubernetes-sigs#8669)
  Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692)
  [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688)
  fix: reset docker was not removing docker properly (kubernetes-sigs#8680)
  Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683)
  split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677)
  [crun] upgrade to 1.4.4 (kubernetes-sigs#8675)
  [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679)
  [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671)
  [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676)
  [runc] upgrade to 1.1.1 (kubernetes-sigs#8674)
  [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672)
  ...
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@robinAwallace @sakuraiyuta
UpCloud integration (kubernetes-sigs#8653)
a26769f 
* [upcloud] add upcloud csi-driver

* Option to use ansible_host as api ip for kubueconfig
robinAwallace added a commit to elastisys/kubespray that referenced this pull request May 19, 2022
@robinAwallace
UpCloud integration (kubernetes-sigs#8653)
d2bece7 
* [upcloud] add upcloud csi-driver

* Option to use ansible_host as api ip for kubueconfig
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@robinAwallace @LuckySB
UpCloud integration (kubernetes-sigs#8653)
cad3623 
* [upcloud] add upcloud csi-driver

* Option to use ansible_host as api ip for kubueconfig
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@robinAwallace @LuckySB
UpCloud integration (kubernetes-sigs#8653)
7d37220 
* [upcloud] add upcloud csi-driver

* Option to use ansible_host as api ip for kubueconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xartos Xartos Xartos left review comments

@OlleLarsson OlleLarsson OlleLarsson approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@LuckySB LuckySB Awaiting requested review from LuckySB

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robinAwallace @k8s-ci-robot @llarsson @oomichi @cristicalin @Xartos @OlleLarsson