Enable Kubespray deployment on vagrant #8697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Testing this at local env /hold |
k8s-ci-robot
added
the
do-not-merge/hold
cristicalin
reviewed
Apr 8, 2022
Current ansible.tags 'facts' is for skipping actual Kubespray deployment at vagrant CI because the deployment takes much time. However the static 'facts' skips the deployment for normal usage of vagrant also. That causes confusions. This adds VAGRANT_ANSIBLE_TAGS to skip the deployment for vagrant CI.
|
succeeded to pass a test locally. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Thanks @oomichi ! /lgtm |
k8s-ci-robot
added
the
lgtm
Quehenr
pushed a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Apr 14, 2022
* master: (21 commits) Add tz to kubespray image Add tag to AWS VPC subnets for automatic subnet discovery by load balancers or ingress controllers (kubernetes-sigs#8705) Enable external CA mode for control-plane deployment (kubernetes-sigs#8620) UpCloud integration (kubernetes-sigs#8653) Fixes for Hetzner terraform and Hetzner Cloud (kubernetes-sigs#8702) Add VAGRANT_ANSIBLE_TAGS for normal deployment (kubernetes-sigs#8697) Removed quotation of nerdctl_extra_flags. (kubernetes-sigs#8695) [calico] add calico apiserver (kubernetes-sigs#8690) Add support for kube-vip (kubernetes-sigs#8669) Ensure all Kubelet required kernel values are configured when enabling protectKernelDefaults (kubernetes-sigs#8692) [cert-manager] Upgrade to v1.8.0 (kubernetes-sigs#8688) fix: reset docker was not removing docker properly (kubernetes-sigs#8680) Single quotes are missing in jsonpath argument of kubectl get node (kubernetes-sigs#8683) split kube_feature_gates variable for different kubernetes components (kubernetes-sigs#8677) [crun] upgrade to 1.4.4 (kubernetes-sigs#8675) [validate-container-engine] check if kubelet is present was not working (kubernetes-sigs#8679) [containerd] upgrade versions to address CVE-2022-24769 (kubernetes-sigs#8671) [vsphere_csi] update to 2.5.1 and make external_vsphere_version 7.0u1 by default (kubernetes-sigs#8676) [runc] upgrade to 1.1.1 (kubernetes-sigs#8674) [nerdctl] upgrade to 0.18.0 (kubernetes-sigs#8672) ...
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
Current ansible.tags 'facts' is for skipping actual Kubespray deployment at vagrant CI because the deployment takes much time. However the static 'facts' skips the deployment for normal usage of vagrant also. That causes confusions. This adds VAGRANT_ANSIBLE_TAGS to skip the deployment for vagrant CI.
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
Current ansible.tags 'facts' is for skipping actual Kubespray deployment at vagrant CI because the deployment takes much time. However the static 'facts' skips the deployment for normal usage of vagrant also. That causes confusions. This adds VAGRANT_ANSIBLE_TAGS to skip the deployment for vagrant CI.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
Current ansible.tags 'facts' is for skipping actual Kubespray deployment at vagrant CI because the deployment takes much time. However the static 'facts' skips the deployment for normal usage of vagrant also. That causes confusions. This adds VAGRANT_ANSIBLE_TAGS to skip the deployment for vagrant CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Current ansible.tags 'facts' is for skipping actual Kubespray deployment at vagrant CI
because the deployment takes much time.
However the static 'facts' skips the deployment for normal usage of vagrant also.
That causes confusions.
This adds VAGRANT_ANSIBLE_TAGS to skip the deployment for vagrant CI.
Which issue(s) this PR fixes:
Fixes #8682
Does this PR introduce a user-facing change?: