Allow hosts with hyphen in name #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
confirmed this PR works fine on my local env. /lgtm |
k8s-ci-robot
added
the
lgtm
mattymo
reviewed
Aug 18, 2020
| @@ -238,7 +238,7 @@ def ips(start_address, end_address): | |||
| return [ip_address(ip).exploded for ip in range(start, end + 1)] | |||
|
|
|||
| for host in hosts: | |||
| if '-' in host and not host.startswith('-'): | |||
| if '-' in host and not (host.startswith('-') or host[0].isalpha()): | |||
There was a problem hiding this comment.
Took me some time to figure out that if the first char is a letter, it has to be a host, not a range. This is okay
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mattymo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Aug 18, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: Allow hosts with hyphen in name (kubernetes-sigs#6529) Update apiserver-audit-policy.yaml.j2 (kubernetes-sigs#6526) add master_volume_type variable (kubernetes-sigs#6524) Remove unused variable (kubernetes-sigs#6522) Add new cilium options for native routing (kubernetes-sigs#6519) Fixed Kubespray container-engine/docker role to populate docker.service (kubernetes-sigs#6518) Fix cilium_deploy_additionally with kubeadm etcd (kubernetes-sigs#6514) improve Cilium metrics support (kubernetes-sigs#6513)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Hostname with hyphen should be allowed
Which issue(s) this PR fixes:
Fixes #6509
Special notes for your reviewer:
Tests ok
Does this PR introduce a user-facing change?: