Fixed Kubespray container-engine/docker role to populate docker.service

[thegreenbear]

What type of PR is this?
/kind bug

What this PR does / why we need it:
It deploys the docker.service file. Without this deployment, container options configured in Kubespray are never applied.

Which issue(s) this PR fixes:
Fixes #6348

Special notes for your reviewer:
First PR I make to this repo. Let me know if I missed something in the process.

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @thegreenbear!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @thegreenbear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@thegreenbear Thank you for the PR, could you please sign CLA ?

[floryut]

/ok-to-test

[thegreenbear]

@thegreenbear Thank you for the PR, could you please sign CLA ?

@floryut , I just did. My understanding is it can take some time to propagate.
Do I need to do anything to restart the check or it's automatic?
Edit: looks like it's OK now.

[floryut]

That's indeed strange as there is a check in docker.service file on os_tree value...

{% if not is_ostree and systemd_version.stdout|int >= 226 %}
TasksMax=infinity
{% endif %}

Weird not to have it copied to fit kubespray templating 🤔

[thegreenbear]

Weird not to have it copied to fit kubespray templating 🤔

Indeed :-D

[thegreenbear]

So I think this PR is only missing your approval @floryut or @holmsten .
Let me know if you have questions :-D

[floryut]

Fine by me, WDYT @Miouge1 ?
/lgtm

[thegreenbear]

Hey there!
What is the next step and what are we waiting for?
Cheers,

[floryut]

Hey there!
What is the next step and what are we waiting for?
Cheers,

None on your end, waiting on an approver to /approve your PR

[mattymo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, thegreenbear

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattymo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment