Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new cilium options for native routing #6519

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Add new cilium options for native routing #6519

merged 1 commit into from
Aug 18, 2020

Conversation

MrFreezeex
Copy link
Member

Signed-off-by: Arthur Outhenin-Chalandre [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR add cilium options to add native routing. With It you can set the tunnel to disable with the auto direct nodes route feature or use kube-router to achieve the same kind of setup
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add new cilium options for native routing

@MrFreezeex
Add new cilium options for native routing
2d2574c 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut August 10, 2020 16:33
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @MrFreezeex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2020
@floryut
Copy link
Member

floryut commented Aug 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2020
oomichi
oomichi reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

roles/network_plugin/cilium/defaults/main.yml
# make this work. Please refer to the cilium documentation for more
# information about this kind of setups.
cilium_auto_direct_node_routes: false
cilium_native_routing_cidr: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.cilium.io/en/v1.8/concepts/networking/routing/?highlight=auto-direct-node-routes#configuration this addition seems good for me.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@mattymo
Copy link
Contributor

mattymo commented Aug 18, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit ca8e59f into kubernetes-sigs:master Aug 18, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Aug 18, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
3cd81d6 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Allow hosts with hyphen in name (kubernetes-sigs#6529)
  Update apiserver-audit-policy.yaml.j2 (kubernetes-sigs#6526)
  add master_volume_type variable (kubernetes-sigs#6524)
  Remove unused variable (kubernetes-sigs#6522)
  Add new cilium options for native routing (kubernetes-sigs#6519)
  Fixed Kubespray container-engine/docker role to populate docker.service (kubernetes-sigs#6518)
  Fix cilium_deploy_additionally with kubeadm etcd (kubernetes-sigs#6514)
  improve Cilium metrics support (kubernetes-sigs#6513)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
@MrFreezeex @LuckySB
Add new cilium options for native routing (kubernetes-sigs#6519)
5187b90 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@MrFreezeex MrFreezeex mentioned this pull request Mar 14, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@EppO EppO Awaiting requested review from EppO

@floryut floryut Awaiting requested review from floryut

Assignees

@mattymo mattymo

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrFreezeex @k8s-ci-robot @floryut @mattymo @oomichi