Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apiVersion for audit policy #6526

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix apiVersion for audit policy #6526

merged 1 commit into from
Aug 18, 2020

Conversation

holmesb
Copy link
Contributor

@holmesb holmesb commented Aug 12, 2020

Should be apiVersion: audit.k8s.io/v1 not audit.k8s.io/v1beta1

Has been v1 since k8s v1.14 or earlier.

Fixes issue #6525

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @holmesb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and floryut August 12, 2020 13:17
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2020
@floryut
Copy link
Member

floryut commented Aug 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2020
@floryut
Copy link
Member

floryut commented Aug 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@oomichi
Copy link
Contributor

oomichi commented Aug 12, 2020

/lgtm

@mattymo
Copy link
Contributor

mattymo commented Aug 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holmesb, mattymo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit d8a749f into kubernetes-sigs:master Aug 18, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Aug 18, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
3cd81d6 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Allow hosts with hyphen in name (kubernetes-sigs#6529)
  Update apiserver-audit-policy.yaml.j2 (kubernetes-sigs#6526)
  add master_volume_type variable (kubernetes-sigs#6524)
  Remove unused variable (kubernetes-sigs#6522)
  Add new cilium options for native routing (kubernetes-sigs#6519)
  Fixed Kubespray container-engine/docker role to populate docker.service (kubernetes-sigs#6518)
  Fix cilium_deploy_additionally with kubeadm etcd (kubernetes-sigs#6514)
  improve Cilium metrics support (kubernetes-sigs#6513)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 10, 2021
@holmesb @LuckySB
Update apiserver-audit-policy.yaml.j2 (kubernetes-sigs#6526)
8a4d692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@floryut floryut Awaiting requested review from floryut

Assignees

@oomichi oomichi

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@holmesb @k8s-ci-robot @floryut @oomichi @mattymo