Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hosts with hyphen in name #6529

Merged
merged 1 commit into from
Aug 18, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/inventory_builder/inventory.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def ips(start_address, end_address):
return [ip_address(ip).exploded for ip in range(start, end + 1)]

for host in hosts:
if '-' in host and not host.startswith('-'):
if '-' in host and not (host.startswith('-') or host[0].isalpha()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me some time to figure out that if the first char is a letter, it has to be a host, not a range. This is okay

start, end = host.strip().split('-')
try:
reworked_hosts.extend(ips(start, end))
Expand Down