Implement forums #684
Merged
Implement forums #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
requested changes
Sep 11, 2022
| import kotlin.contracts.InvocationKind | ||
| import kotlin.contracts.contract | ||
|
|
||
| public interface ForumChannelBehavior : ThreadParentChannelBehavior { |
There was a problem hiding this comment.
this is missing an extension to create a thread, see here
# Conflicts: # common/src/main/kotlin/entity/DiscordChannel.kt
# Conflicts: # common/src/main/kotlin/entity/DiscordChannel.kt # core/api/core.api # core/src/main/kotlin/entity/channel/Channel.kt
# Conflicts: # common/src/main/kotlin/entity/DiscordChannel.kt
* Add missing properties for create forum channel * api dump * add missing fields in the other builders * api dump * move flags to forum threads * apply suggestions * Small fixes Co-authored-by: Lukellmann <[email protected]>
# Conflicts: # common/build/generated/ksp/main/kotlin/dev/kord/common/entity/ChannelType.kt # core/api/core.api # core/src/main/kotlin/entity/channel/Channel.kt
luisfbl
reviewed
Nov 19, 2022
# Conflicts: # rest/src/main/kotlin/json/JsonErrorCode.kt
* Message counts and position for channel and message * Api Dump * Is this dump better? * Update caches for message count and total message sent * Fix merge
# Conflicts: # common/api/common.api # core/api/core.api # core/src/main/kotlin/cache/data/MessageData.kt # core/src/main/kotlin/entity/Message.kt # rest/api/rest.api # rest/src/main/kotlin/builder/message/create/WebhookMessageCreateBuilder.kt # rest/src/main/kotlin/json/request/WebhookRequests.kt
* support for creating forum posts * api dump * support for uploading files on forum posts * more support to forums and forum threads * fix errors * maintain code consistency * add forum tag routes * Api Dump * Update Intent KDoc * Check for applied tags * Remove ForumChannelThread type * Move possible functions to ForumChannelBehavior * add applied tags to modify builder * Properly configure JVM auto-provisioning * Fix appliedTags mutability * Fix spacings * Final fixes --------- Co-authored-by: Luis <[email protected]> Co-authored-by: Lukellmann <[email protected]> Co-authored-by: hope <[email protected]> Co-authored-by: Michael Rittmeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant doc PRs:
ChannelType.GuildForumChannelFlag+ChannelFlagsDiscordChannel.flagsandChannelData.flagsThreadParentChannel(keepactiveThreadsandgetPublicArchivedThreads()) but noTopGuildMessageChannel, however it also needs a new thread creation method, as it's different from both creating a thread from an existing message and without a message: threads created in forum channels always also create a message -> new builder that is a message create builder and a thread create builder, see https://discord.com/developers/docs/resources/channel#start-thread-in-forum-channelThreadCreateevents to update cachedChannelData.lastMessageId(same asMessageCreatefor normal message channels)(only the new
flagsfields indocs/resources/Channel.mdis relevant from this PR)WebhookExecuteRequest.threadNameandWebhookMessageCreateBuilder.threadNameDiscordChannel.totalMessageSentandChannelData.totalMessageSent-> also add on core thread channel typesDiscordMessge.position,MessageData.position,Message.positionmessageCountandtotalMessageSentonMessageCreate,MessageDeleteandMessageDeleteBulkavailableTags,appliedTags,defaultReactionEmojianddefaultThreadRateLimitPerUserforDiscordChannel,ChannelDataand on appropriate core channel typesavailableTags,defaultReactionEmojianddefaultThreadRateLimitPerUserfor channel modify buildersChannelFlag.RequireTagappliedTagsin builders for starting and modifying threads in forum channelsavailableTags,defaultReactionEmojianddefaultThreadRateLimitPerUserfor channel create buildersSortOrderTypekord enumDiscordChannel.defaultSortOrderandChannelData.defaultSortOrder-> also add on core forum channel typedefaultSortOrderin forum create / modify buildersnameis required discord/discord-api-docs#5458ForumLayoutTypekord enumDiscordChannel.defaultForumLayoutandChannelData.defaultForumLayout-> also add on core forum channel typedefaultForumLayoutin builders