Forum posts #709
Merged
Forum posts #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't the |
|
do you mean |
|
Yes |
|
the name follows discord docs, I also agree it should be renamed to create |
|
hm ok. The Discord docs don't really make much sense. It's creating a forum thread, not just a thread 🤔 |
|
true lol |
NoComment1105
approved these changes
Nov 8, 2022
|
Don't review yet, I want to add some things that were missing |
# Conflicts: # core/api/core.api # core/src/main/kotlin/cache/data/ChannelData.kt
luisfbl
commented
Nov 24, 2022
luisfbl
commented
Nov 24, 2022
core/src/main/kotlin/entity/channel/thread/ForumChannelThread.kt
Outdated
Show resolved
Hide resolved
luisfbl
commented
Nov 24, 2022
core/src/main/kotlin/entity/channel/thread/TextChannelThread.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # rest/src/main/kotlin/builder/channel/thread/StartThreadBuilder.kt # rest/src/main/kotlin/builder/channel/thread/StartThreadWithMessageBuilder.kt
luisfbl
commented
Nov 26, 2022
luisfbl
commented
Nov 27, 2022
core/src/main/kotlin/behavior/channel/threads/ForumChannelThreadBehavior.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # common/src/main/kotlin/entity/DiscordChannel.kt # core/api/core.api # core/src/main/kotlin/cache/data/ChannelData.kt # core/src/main/kotlin/entity/channel/ForumChannel.kt # rest/src/main/kotlin/builder/channel/EditGuildChannelBuilder.kt # rest/src/main/kotlin/builder/channel/ForumChannelCreateBuilder.kt
|
The PR does more than the changed documentation do, is this intentional? |
lukellmann
reviewed
Feb 19, 2023
I wanted to take advantage of the pull request, as this is part of the forums, but if you want I can make a separate one |
# Conflicts: # core/api/core.api
HopeBaron
requested changes
Mar 18, 2023
core/src/main/kotlin/entity/channel/thread/ForumChannelThread.kt
Outdated
Show resolved
Hide resolved
NoComment1105
suggested changes
Mar 19, 2023
rest/src/main/kotlin/builder/channel/thread/ThreadModifyBuilder.kt
Outdated
Show resolved
Hide resolved
NoComment1105
approved these changes
Mar 19, 2023
HopeBaron
added a commit
that referenced
this pull request
Mar 20, 2023
* add forum error codes * update docs of Permission.SendMessages for forums * add ChannelType.GuildForum * add ChannelFlags * add DiscordChannel.flags * add ChannelData.flags * add Channel.flags * add cache updates for lastMessageId of forum channels * Implmenet high level abstractions * Error 220003 * API dump * Fix compile error * More error codes * Add `ChannelFlag.RequireTag` * Add `thread_name` for execute webhook * Regenerate `ChannelType` * Remove `nsfwLevel` from channel * Dump API * Add SortOrderType * Add missing fields to DiscordChannel * Imports * Add missing properties for channel builders (#712) * Add missing properties for create forum channel * api dump * add missing fields in the other builders * api dump * move flags to forum threads * apply suggestions * Small fixes Co-authored-by: Lukellmann <[email protected]> * TextChannelModifyBuilder.defaultThreadRateLimitPerUser * Update KDoc for ChannelType.PublicGuildThread see discord/discord-api-docs#5556 * Add ChannelData.defaultSortOrder (#727) * Add default forum layout (#749) * Fix nullability and docs * Add missing default layout to core type (#752) * Message counts and position for channel and message (#726) * Message counts and position for channel and message * Api Dump * Is this dump better? * Update caches for message count and total message sent * Fix merge * Forum posts (#709) * support for creating forum posts * api dump * support for uploading files on forum posts * more support to forums and forum threads * fix errors * maintain code consistency * add forum tag routes * Api Dump * Update Intent KDoc * Check for applied tags * Remove ForumChannelThread type * Move possible functions to ForumChannelBehavior * add applied tags to modify builder * Properly configure JVM auto-provisioning * Fix appliedTags mutability * Fix spacings * Final fixes --------- Co-authored-by: Luis <[email protected]> Co-authored-by: Lukellmann <[email protected]> Co-authored-by: hope <[email protected]> Co-authored-by: Michael Rittmeister <[email protected]> --------- Co-authored-by: Lukellmann <[email protected]> Co-authored-by: Lukellmann <[email protected]> Co-authored-by: Luis <[email protected]> Co-authored-by: NoComment <[email protected]> Co-authored-by: Michael Rittmeister <[email protected]> Co-authored-by: Luis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discord/discord-api-docs#4850