-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing properties for channel builders #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also order the newly added properties for builders and requests the same way as in Discord's docs - that makes it easier to compare them side-by-side.
rest/src/main/kotlin/builder/channel/EditGuildChannelBuilder.kt
Outdated
Show resolved
Hide resolved
rest/src/main/kotlin/builder/channel/EditGuildChannelBuilder.kt
Outdated
Show resolved
Hide resolved
rest/src/main/kotlin/builder/channel/ForumChannelCreateBuilder.kt
Outdated
Show resolved
Hide resolved
rest/src/main/kotlin/builder/channel/ForumChannelCreateBuilder.kt
Outdated
Show resolved
Hide resolved
rest/src/main/kotlin/builder/channel/TextChannelCreateBuilder.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things that I will commit directly. Thanks!
* add forum error codes * update docs of Permission.SendMessages for forums * add ChannelType.GuildForum * add ChannelFlags * add DiscordChannel.flags * add ChannelData.flags * add Channel.flags * add cache updates for lastMessageId of forum channels * Implmenet high level abstractions * Error 220003 * API dump * Fix compile error * More error codes * Add `ChannelFlag.RequireTag` * Add `thread_name` for execute webhook * Regenerate `ChannelType` * Remove `nsfwLevel` from channel * Dump API * Add SortOrderType * Add missing fields to DiscordChannel * Imports * Add missing properties for channel builders (#712) * Add missing properties for create forum channel * api dump * add missing fields in the other builders * api dump * move flags to forum threads * apply suggestions * Small fixes Co-authored-by: Lukellmann <[email protected]> * TextChannelModifyBuilder.defaultThreadRateLimitPerUser * Update KDoc for ChannelType.PublicGuildThread see discord/discord-api-docs#5556 * Add ChannelData.defaultSortOrder (#727) * Add default forum layout (#749) * Fix nullability and docs * Add missing default layout to core type (#752) * Message counts and position for channel and message (#726) * Message counts and position for channel and message * Api Dump * Is this dump better? * Update caches for message count and total message sent * Fix merge * Forum posts (#709) * support for creating forum posts * api dump * support for uploading files on forum posts * more support to forums and forum threads * fix errors * maintain code consistency * add forum tag routes * Api Dump * Update Intent KDoc * Check for applied tags * Remove ForumChannelThread type * Move possible functions to ForumChannelBehavior * add applied tags to modify builder * Properly configure JVM auto-provisioning * Fix appliedTags mutability * Fix spacings * Final fixes --------- Co-authored-by: Luis <[email protected]> Co-authored-by: Lukellmann <[email protected]> Co-authored-by: hope <[email protected]> Co-authored-by: Michael Rittmeister <[email protected]> --------- Co-authored-by: Lukellmann <[email protected]> Co-authored-by: Lukellmann <[email protected]> Co-authored-by: Luis <[email protected]> Co-authored-by: NoComment <[email protected]> Co-authored-by: Michael Rittmeister <[email protected]> Co-authored-by: Luis <[email protected]>
see discord/discord-api-docs#5474