Add note about new tags when modifying a forum channel: only name is required
#5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm is there a reason this sort of info isn't in the tag object instead, since that's where the https://discord.com/developers/docs/resources/channel#forum-tag-object-forum-tag-structure |
I was thinking about that before, and I decided to put that on the Modify Channel route section because that information is applied more specifically in that part, but I will change it to the tag object |
|
this feels more awkward tbh; it's not really a note on the name field |
What do you mean? What can I change? |
almeidx
added a commit
to suneettipirneni/discord.js
that referenced
this pull request
Sep 17, 2022
Bluenix2
reviewed
Sep 17, 2022
kodiakhq bot
pushed a commit
to discordjs/discord.js
that referenced
this pull request
Sep 18, 2022
* feat: add support for guild forums * feat(webhook): add support for creating forum channel posts * fix: duplicated docs * feat: add support for message counts * feat: add support for latest upstream changes * fix: serialize forum channels * types: fix channel unions * types: fix tests * types: fix tests (again) * types: fix tests (again (again)) * chore: make requested changes * chore: fix bugs and make requested changes * types: use correct type for guild forum start messages * chore: remove console.log * chore: make requested changes * chore: make requested changes * chore: fix docs * Update packages/discord.js/src/managers/GuildForumThreadManager.js Co-authored-by: Jiralite <[email protected]> * chore: update types * chore: make requested changes * chore: Apply suggestions Co-authored-by: Jaworek <[email protected]> Co-authored-by: Jonathan Rubenstein <[email protected]> * fix: import `ErrorCodes` * fix: remove defunct code * refactor: be consistent with channel class names * feat(GuildChannel): add flags * fix: rename file * refactor: channel flags are everywhere! * fix: import flags correctly * chore(ThreadChannel): update message count string * docs(Channels): correct `@param` type * docs(Channels): ignore transformGuildDefaultReaction * refactor: emoji object in tags * chore: renaming consistency * fix: document default reaction emojis in patching * fix(GuildChannelManager): document `defaultThreadRateLimitPerUser` * chore: semicolon * docs(ErrorCodes): document `GuildForumMessageRequired` * refactor: transform default reactions * docs(APITypes): Add `ChannelFlags` * fix: convert tags properly * fix: pass an array of snowflakes * refactor: handle flags better * fix(ThreadChannel): receive tags * fix(PartialGroupDMChannel): nullify `flags` Apparently did not do this earlier. * chore: misc sorting * refactor: nullify emoji on tags if not present * refactor(ForumChannel): modify returns * types: protect the thread manager! Co-authored-by: SpaceEEC <[email protected]> * chore: update `ChannelType` usage * Update index.d.ts * docs: Update default reaction emoji property names Co-authored-by: Almeida <[email protected]> * fix: only `name` is required when editing tags - discord/discord-api-docs#5458 * types: add tests for `channel.flags` * fix: allow unsetting the default reaction emoji * refactor: remove v13 remnants * docs: add missing closing tag * feat: add `rateLimitPerUser` * feat: add missing properties for create guild channel - discord/discord-api-docs#5474 * refactor(GuildForumThreadManager): refactor message payload * fix: handle magical `null` case Co-authored-by: A. Román <[email protected]> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jaworek <[email protected]> Co-authored-by: Jonathan Rubenstein <[email protected]> Co-authored-by: SpaceEEC <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: A. Román <[email protected]>
shaydewael
requested changes
Sep 19, 2022
|
what about putting the note above the table instead of as a footnote? |
Co-authored-by: Shay DeWael <[email protected]>
shaydewael
reviewed
Sep 21, 2022
|
sorry for switch up on organization @Mateo-tem—i made direct suggestions so hopefully it's easier. |
Co-authored-by: Shay DeWael <[email protected]>
shaydewael
approved these changes
Sep 22, 2022
38 tasks
Nihlus
added a commit
to Remora/Remora.Discord
that referenced
this pull request
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note about tags when modifying a forum channel. When creating new tags, only the
namefield is required