Fix breaking changes before release #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default argument can be reintroduced in the future, when the other overloads are removed.
lukellmann
changed the title
NewsChannelBehavior was missing TopGuildMessageChannelBehavior as a supertype since ThreadParentChannelBehavior is no longer a TopGuildMessageChannelBehavior. TextChannelBehavior was missing TopGuildMessageChannelBehavior as a supertype since PrivateThreadParentChannelBehavior is no longer a TopGuildMessageChannelBehavior. ThreadParentChannelBehavior was extended to be a CategorizableChannelBehavior (implicating that ThreadParentChannel was als extended to be a CategorizableChannel) TextChannelBehavior's startPublicThread and startPrivateThread had an additional reason parameter added, breaking binary compatibility. The reason can be specified in the builder lambda. TextChannelBehavior.startPublicThreadWithMessage had the archiveDuration parameter removed, breaking binary compatibility.
There was binary incompatibility in Integration and missing Optional default values in IntegrationData.
lukellmann
changed the title
Before ForumChannels would take the else path resulting in UnknownChannel events.
It's not serialized, so making it optional and nullable is useless.
They aren't queried through cache so putting them there doesn't make sense.
This preserves binary compatibility. Also add the old constructor.
They are not documented in Discord's docs and have odd behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some breakages (e.g. here) were detected with the merge of #684, this tries to fix them to avoid releasing these breaking changes.