Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options in mailtemplate form #37683

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Apr 28, 2022

Pull Request for Issue # .

Summary of Changes

Fix a copy paste error in template form

Testing Instructions

Code inspect - or apply the patch and make sure that tabs in mail templates are still correct
grafik

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 28, 2022
@brianteeman
Copy link
Contributor

it is a bug but why not use the existing generic string JOPTIONS?

@chmst
Copy link
Contributor Author

chmst commented Apr 28, 2022

Valid point. At the moment, every component has it's own label. Search for "LABEL="Options".

Personally I would like to have here a more specific name, maybe "mail options" but kept the standard language string.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683.

@brianteeman
Copy link
Contributor

Took me a while to find this view - for other testers you have to set the per template setting in the options

image

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on d37e08f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683.

1 similar comment
@toivo
Copy link
Contributor

toivo commented Apr 29, 2022

I have tested this item ✅ successfully on d37e08f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 29, 2022
@bembelimen bembelimen merged commit 7171a6a into joomla:4.1-dev Apr 30, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 30, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.3 milestone Apr 30, 2022
heelc29 added a commit to heelc29/joomla that referenced this pull request May 2, 2022
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
@chmst chmst deleted the mails-form-typo branch August 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants