-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix options in mailtemplate form #37683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a bug but why not use the existing generic string JOPTIONS? |
Valid point. At the moment, every component has it's own label. Search for "LABEL="Options". Personally I would like to have here a more specific name, maybe "mail options" but kept the standard language string. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683. |
I have tested this item ✅ successfully on d37e08f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683. |
1 similar comment
I have tested this item ✅ successfully on d37e08f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37683. |
Thx |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
May 2, 2022
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
May 2, 2022
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix a copy paste error in template form
Testing Instructions
Code inspect - or apply the patch and make sure that tabs in mail templates are still correct