-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x]Upload and Update #37519
[4.x]Upload and Update #37519
Conversation
Change the link with long text that is apparently confusing people to shorter text that is styled like a button
Is there a reason this button should not be inline and the same size with the other two ones? |
yes absolutely. its not a preferred option hence it is smaller and below. just as the link text was before |
administrator/components/com_joomlaupdate/tmpl/joomlaupdate/noupdate.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 2718226 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519. |
I have tested this item ✅ successfully on 2718226 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519. |
I am not a designer, I look at the result as a normal user. It looks terrible. |
Adding here the RLDQ label. |
ReleasLeadDecisionQueue because of one opinion to the contrary? The word 'msnually' does not belong to the string. It causes confusion and it needs to go. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519. |
We are de facto in a "admin management app", for a good UX actions need to be identified by buttons. |
@simbus82 In any case, the decision is up to the maintainers. |
@Kostelano |
I'm ok with the button but I have some doubts about the text. Probably it's a thing as I'm not a native speaker, but I'm missing the "what should I upload" information. "Update by uploading the update package" Something like that (although I'm still not 100% happy)? |
It's the text that's causing the problems |
@bembelimen 'Upload and Update' is also used in the helpscreen linked to from the Component |
I really disagree with keeping unused strings for core components. It makes no logical seense to me at all so to move this forward I have changed this pr to keep the strings with the new values |
Not many rules, it's in the B/C promise... Thx |
Doesn't mean it makes sense ;) |
Thx |
thanks - got there in the end |
Thank you everyone! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519. |
Thank you especially @brianteeman |
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
Change the link with long text that is apparently confusing people to shorter text that is styled like a button
Pull Request for Issue #37512 .
After