Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]Upload and Update #37519

Merged
merged 6 commits into from
May 1, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

Change the link with long text that is apparently confusing people to shorter text that is styled like a button

Pull Request for Issue #37512 .

After

image

Change the link with long text that is apparently confusing people to shorter text that is styled like a button
@laoneo
Copy link
Member

laoneo commented Apr 8, 2022

Is there a reason this button should not be inline and the same size with the other two ones?

@brianteeman
Copy link
Contributor Author

yes absolutely. its not a preferred option hence it is smaller and below. just as the link text was before

@toivo
Copy link
Contributor

toivo commented Apr 8, 2022

I have tested this item ✅ successfully on 2718226

Tested successfully in Joomla 4.2.3-dev of 8 April in Wampserver 3.2.7 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

@Webdongle
Copy link
Contributor

I have tested this item ✅ successfully on 2718226

Success


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

@alikon
Copy link
Contributor

alikon commented Apr 8, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 8, 2022
@Kostelano
Copy link
Contributor

I am not a designer, I look at the result as a normal user. It looks terrible.
The string option was better.

@laoneo laoneo added the RMDQ ReleaseManagerDecisionQueue label Apr 9, 2022
@laoneo
Copy link
Member

laoneo commented Apr 9, 2022

Adding here the RLDQ label.

@toivo
Copy link
Contributor

toivo commented Apr 9, 2022

ReleasLeadDecisionQueue because of one opinion to the contrary?

The word 'msnually' does not belong to the string. It causes confusion and it needs to go.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

@Kostelano
Copy link
Contributor

Just for thought. Why not put "Upload and Install" and "Reinstall" buttons in the toolbar? How do I get into the menu for reinstalling kernel files now? I can not.

Screenshot_1

@Webdongle
Copy link
Contributor

Just for thought. Why not put "Upload and Install" and "Reinstall" buttons in the toolbar? How do I get into the menu for reinstalling kernel files now? I can not.

That is a different issue.
btw
reinstall 01

Although tabs like in J3 would imho be better. But the powers that be decided on this design. Anyway it is the wording itself this is dealing with. If you want to change the layout start another tracker and create a patch for that.

@simbus82
Copy link
Contributor

simbus82 commented Apr 11, 2022

I am not a designer, I look at the result as a normal user. It looks terrible. The string option was better.

We are de facto in a "admin management app", for a good UX actions need to be identified by buttons.
A linked text is wrong in this type of UI, this isn't a webpage. (for example, it would make more sense to refer to an external page of the guide as linked text and not as a button).

@Kostelano
Copy link
Contributor

@simbus82
It doesn't matter to me - a button or a line - both can be a good solution, BUT. I'm talking about the fact that THIS visual solution loses to the original version. Perhaps if the button could be implemented in the same size/style, and also placed in a better place (it's hard for me to think of a better one, except for, for example, a toolbar), this would be a better solution.

In any case, the decision is up to the maintainers.

@Webdongle
Copy link
Contributor

Webdongle commented Apr 11, 2022

@Kostelano
The position is in the same place as the incorrect text was. The size of the button balances the page. But it is not about the position it is about the fact that the wording needs to be changed to 'Upload and Update'. Please stop derailing this thread by making off topic comments. If you want the position changed please start another separate tracker.

@bembelimen
Copy link
Contributor

I'm ok with the button but I have some doubts about the text. Probably it's a thing as I'm not a native speaker, but I'm missing the "what should I upload" information.

"Update by uploading the update package"

Something like that (although I'm still not 100% happy)?

@brianteeman
Copy link
Contributor Author

It's the text that's causing the problems

@brianteeman
Copy link
Contributor Author

All that information is on the next page

image

@Webdongle
Copy link
Contributor

@bembelimen
'Upload and Update' is the wording that has been used for at least 7 years. Why wait until now to object to it's use?

'Upload and Update' is also used in the helpscreen linked to from the Component
https://help.joomla.org/proxy?keyref=Help41:Joomla_Update#Upload_and_Update
"You can use this feature to update Joomla if your server is behind a firewall or otherwise unable to contact the update servers. First download the Joomla Upgrade Package in ZIP format from the official Joomla download page."

@bembelimen
Copy link
Contributor

All that information is on the next page

image

Fair enough, just we shouldn't remove existing language strings then I'm ok.

@brianteeman
Copy link
Contributor Author

brianteeman commented Apr 30, 2022

Fair enough, just we shouldn't remove existing language strings then I'm ok.

I really disagree with keeping unused strings for core components. It makes no logical seense to me at all so to move this forward I have changed this pr to keep the strings with the new values

@bembelimen
Copy link
Contributor

Not many rules, it's in the B/C promise... Thx

@brianteeman
Copy link
Contributor Author

Not many rules, it's in the B/C promise... Thx

Doesn't mean it makes sense ;)

@bembelimen bembelimen merged commit 11dbbdf into joomla:4.1-dev May 1, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 1, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.3 milestone May 1, 2022
@brianteeman
Copy link
Contributor Author

thanks - got there in the end

@brianteeman brianteeman deleted the upload_and_update branch May 1, 2022 11:28
@toivo
Copy link
Contributor

toivo commented May 1, 2022

Thank you everyone!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37519.

@Webdongle
Copy link
Contributor

Thank you especially @brianteeman

Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators RMDQ ReleaseManagerDecisionQueue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants