-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Improve the child template creation #36250
[4.1] Improve the child template creation #36250
Conversation
If we offer this option, it should be a multiple select I think (fancy select + required) PS: the button in the model should be "Create" (bottom right) |
Brian has a PR for this #36228
We can only apply one existing style to the child or am I getting this wrong? |
I think so, you can copy any style, as the child is a "normal" template you can have multiple |
Yes please merge that for the beta as it will make things a little easier to understand |
Ok but that's a different thing than what the code is actually doing here. Let me explain: When the child is installed it creates a default style based on the values of the XML file. The select element here just overrides these values to the ones from the parent template style that was selected (if something other than default was selected). Creating additional styles is possible but what would be the titles for them? (prepend them with the child name and removing the parent from the string could be an option). Anyways that would be probably an extra select element |
administrator/components/com_templates/src/Model/TemplateModel.php
Outdated
Show resolved
Hide resolved
….php Co-authored-by: Benjamin Trenkle <[email protected]>
@bembelimen @brianteeman I'm not sure if this is what you were asking for but now a user could freely select styles from the parent or any child from the same parent |
administrator/components/com_templates/tmpl/template/default_modal_child_body.php
Outdated
Show resolved
Hide resolved
…odal_child_body.php Co-authored-by: Quy <[email protected]>
I have tested this item ✅ successfully on 89ff152 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
I have tested this item ✅ successfully on 89ff152 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
I have tested this item ✅ successfully on 686e9eb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
administrator/components/com_templates/src/Model/TemplateModel.php
Outdated
Show resolved
Hide resolved
@bembelimen is there still any interest for this or should I close it? |
Sure, we just need the tests. |
I have tested this item ✅ successfully on ad86e38 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
I have tested this item ✅ successfully on ad86e38 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250. |
Thanks! |
Please see |
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
Pull Request for Issue #36216 (comment) .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
In addition to the docs for the child templates
@bembelimen @brianteeman