Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Improve the child template creation #36250

Merged
merged 37 commits into from
Apr 4, 2022

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #36216 (comment) .

Summary of Changes

  • Adds a select element in the child template creation modal where users can pick any of the existing parent template's styles.
  • The first option (Default) means: apply the existing params from the parent XML file (default)

Screenshot 2021-12-07 at 10 43 23

Screenshot 2021-12-07 at 10 43 17

Testing Instructions

  • Create a new style for Cassiopeia or Atum (give it some distinct name)
  • Try to create a child templates with Default and with the new style you created before
  • Compare that the options in the child are the same as the parent template (the one you created/selected)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

In addition to the docs for the child templates

@bembelimen @brianteeman

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 7, 2021
@bembelimen
Copy link
Contributor

bembelimen commented Dec 7, 2021

If we offer this option, it should be a multiple select I think (fancy select + required)

PS: the button in the model should be "Create" (bottom right)

@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Dec 7, 2021

PS: the button in the model should be "Create" (bottom right)

Brian has a PR for this #36228

it should be a multiple select I think

We can only apply one existing style to the child or am I getting this wrong?

@bembelimen
Copy link
Contributor

it should be a multiple select I think

We can only apply one existing style to the child or am I getting this wrong?

I think so, you can copy any style, as the child is a "normal" template you can have multiple

@brianteeman
Copy link
Contributor

PS: the button in the model should be "Create" (bottom right)

Brian has a PR for this #36228

Yes please merge that for the beta as it will make things a little easier to understand

@dgrammatiko
Copy link
Contributor Author

I think so, you can copy any style, as the child is a "normal" template you can have multiple

Ok but that's a different thing than what the code is actually doing here. Let me explain: When the child is installed it creates a default style based on the values of the XML file. The select element here just overrides these values to the ones from the parent template style that was selected (if something other than default was selected).

Creating additional styles is possible but what would be the titles for them? (prepend them with the child name and removing the parent from the string could be an option). Anyways that would be probably an extra select element

@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Dec 7, 2021

@bembelimen @brianteeman I'm not sure if this is what you were asking for but now a user could freely select styles from the parent or any child from the same parent

Screenshot 2021-12-07 at 21 03 37
Screenshot 2021-12-07 at 21 03 13

Screenshot 2021-12-07 at 21 20 01

@akshitrattan
Copy link

akshitrattan commented Jan 10, 2022

I have successfully tested the issue.
I was able to create a child template and it had the same configuration as the parent template.
Screenshot 2022-01-10 at 1 07 52 PM
Screenshot 2022-01-10 at 1 05 35 PM
This is the only difference
P.S:- cassieopia_wow is the child template

@pritam825
Copy link
Contributor

I have tested this item ✅ successfully on 89ff152


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@akshitrattan
Copy link

I have tested this item ✅ successfully on 89ff152

I have successfully tested the issue.
I was able to create a child template and it had the same configuration as the parent template.
All the styles (CSS, HTML, and js files) of the parent template were included in the directory for the child template as well


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@pritam825
Copy link
Contributor

I am able to create the child template successfully and it has the same configuration as parent
test

check_again is the child template

@pritam825
Copy link
Contributor

I have tested this item ✅ successfully on 686e9eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Jan 17, 2022
@dgrammatiko
Copy link
Contributor Author

@bembelimen is there still any interest for this or should I close it?

@bembelimen
Copy link
Contributor

Sure, we just need the tests.

@bembelimen bembelimen removed this from the Joomla 4.1.1 milestone Mar 18, 2022
@RickR2H
Copy link
Member

RickR2H commented Mar 22, 2022

I have tested this item ✅ successfully on ad86e38

Test was successful! But we need some solid docs on explaining why you can choose multiple style which is essence makes no sense in the context of creating a child theme.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@ricardo1709
Copy link
Contributor

I have tested this item ✅ successfully on ad86e38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@RickR2H
Copy link
Member

RickR2H commented Mar 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 22, 2022
@laoneo laoneo added this to the Joomla 4.1.3 milestone Apr 4, 2022
@laoneo laoneo merged commit 49b0fb5 into joomla:4.1-dev Apr 4, 2022
@laoneo
Copy link
Member

laoneo commented Apr 4, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 4, 2022
@dgrammatiko dgrammatiko deleted the 4.1-dev-child-with-existing-styles branch April 4, 2022 16:26
@infograf768
Copy link
Member

Please see

#37485

Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.