Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] com_content: hardcoded language string #37666

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Apr 26, 2022

Pull Request to fix hard coded error in front-end com_content.

Summary of Changes

The hard coded error "Sorry, Joomla 4 no longer supports print_popup" has been moved to .ini language file and is now translatable.

Testing Instructions

Please check PR via code inspection

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 26, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 65b97da

Tested successfully but same comment as before regarding exceptions


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37666.

@alikon
Copy link
Contributor

alikon commented Apr 26, 2022

I have tested this item ✅ successfully on 65b97da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37666.

@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Apr 26, 2022
@alikon
Copy link
Contributor

alikon commented Apr 26, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37666.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.1-dev labels Apr 26, 2022
@Quy Quy added the PR-4.1-dev label Apr 26, 2022
@bembelimen bembelimen merged commit 0fbd934 into joomla:4.1-dev Apr 30, 2022
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Apr 30, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.3 milestone Apr 30, 2022
@pe7er pe7er deleted the com_content-hardcoded-language branch May 2, 2022 07:13
heelc29 added a commit to heelc29/joomla that referenced this pull request May 2, 2022
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants