Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Missing error strings in installation #37286

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

brianteeman
Copy link
Contributor

Partial PR for #36370
see #36370 (comment)

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Mar 16, 2022
@richard67
Copy link
Member

By review I think the added stings are ok, but I haven't really managed to get one of them shown when making an installation and choosing to install some languages at the end. E.g. I disabled the allow_url_fopen setting but did not get the JLIB_UPDATER_ERROR_COLLECTION_FOPEN message shown anywhere.

@brianteeman
Copy link
Contributor Author

We definitely need the parse string. As the others are related I figured there was no harm in adding thosse as well.

@richard67
Copy link
Member

I have tested this item ✅ successfully on e84078d

By review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

@RickR2H
Copy link
Member

RickR2H commented Mar 25, 2022

@brianteeman
I noticed that the language strings JLIB_UPDATER_ERROR_COLLECTION_FOPEN and JLIB_UPDATER_ERROR_COLLECTION_OPEN_URL aren't used in any file? Can you point me where the strings are used?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

@brianteeman
Copy link
Contributor Author

They are some of the compound strings so you wont be able to seatch the code base for them

@RickR2H
Copy link
Member

RickR2H commented Mar 25, 2022

I have tested this item ✅ successfully on e84078d

I tried differente ways (on WAMP) but was also unable to reproduce the error. But as they are valid text strings I agree with @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-4.1-dev labels Mar 25, 2022
@RickR2H
Copy link
Member

RickR2H commented Mar 25, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37286.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2022
@richard67 richard67 added the Language Change This is for Translators label Mar 25, 2022
@Quy Quy added this to the Joomla 4.1.3 milestone Apr 2, 2022
@Quy Quy merged commit d1513ec into joomla:4.1-dev Apr 2, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2022
@Quy
Copy link
Contributor

Quy commented Apr 2, 2022

Thanks

@brianteeman brianteeman deleted the error_collection branch April 2, 2022 05:58
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants