Isis Retina - Dropdown icons fix #12527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to new Version
…ork with Closures
* Extend test for document html links * Fix mergeHeadData method for html document->_links
* Replaced rand() with mt_rand() projectwide * session package is from the framework so we need to revert that change at this point * fof is an external lib so we need to revert that change at this point * fof is an external lib so we need to revert that change at this point
* JLayoutFile wrong type hint * CS
* cs review for the editor plugin * cs * Update image.php * Call to undefined method stdClass::get()
* Update polyfill.event-uncompressed.js * Update polyfill.event.js * update classlist polyfill * Update polyfill.classlist.js * minor changes * minor changes in doc block
Just a small typo in the comment.
|
Closed due to incorrect base |
|
Just a tip for the future if you just send it against the wrong branch you can change the base branch with the edit button on the top right position. ;) |
|
Thank you @zero-24 Never noticed that before! Learn something new every day :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #12500 .
Summary of Changes
Removes sprite image from dropdown on retina displays.
Testing Instructions
Navigate to article edit. If using a Retina display you should see triple icons on dropdown selects which is incorrect. If not on a retina display, zoom in a few notches on your browser to replicate the issue.
Before Patch
After Patch
Documentation Changes Required
None