-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color field using JLayouts #11030
Color field using JLayouts #11030
Conversation
Do I have to do anything extra to test this PR except applying this PR? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030. |
I have tested this item ✅ successfully on 40b09b8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030. |
* @var boolean $repeat Allows extensions to duplicate elements. | ||
* @var boolean $required Is this field required? | ||
* @var integer $size Size attribute of the input. | ||
* @var boolean $spellchec Spellcheck state for the form field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "k" in spellcheck ... ;-)
(i've seen this typo error in your latest PRs too)
I have tested this item successfully, but i can't mark it on joomla issue tracker as i can't access the website since this morning, telling me "You are a terrible, terrible person." 😞 Note: it happened 2 hours ago, while opening the issue tracker site on my iPhone... |
@JoomliC - everyone has that problem right now - its a server issue we are waiting a fix for |
@brianteeman Thanks! Good to know my mobile is ok ;-) |
I have tested this item ✅ successfully on 40b09b8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030. |
I have tested this item ✅ successfully on 40b09b8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11030. |
Merged with 6aeb68b - thanks! |
Use JLayout for the html output
Summary of Changes
Testing Instructions
To test edit isis template xml and add:
Changing control to
control="simple"
you initiate the simple mode, the advanced is the default.Preview
Simple mode:
Advanced mode: