RETINA displays only - Dropdowns icons looks messy

[htmgarcia]

Steps to reproduce the issue

Create or edit an article, and see the icons on the right side for the dropdowns such as "Access" or "Status"

Expected result

Actual result

System information (as much as possible)

Using Joomla 3.7.x branch
Firefox browser
Mac OS

Additional comments

[brianteeman]

Maybe I am missing something but I dont see what/where the problem is

[brianteeman]

Rechecked current 3.7 branch with chrome, safari and firefox on osx and still can not replicate this

[zero-24]

It is a privat video ;) can you double check that the caches are clean?

[mbabker]

I've got the same issue with my MacBook Pro. So either there's a bug with the upstream Chosen code or our implementation of it.

[andrepereiradasilva]

who told you to buy mac "retina", clearly your iMac in the kitchen works better (why the hell do you have an iMac on the kitchen, to cook? :D just kidding :) )

[andrepereiradasilva]

now kidding aside, so this only manisfests in new macs?

[mbabker]

Mine's not "new" by any means.

MacBook Pro (Retina, 13-inch, Late 2013)

[mbabker]

Shoulda held out a few weeks. Isn't this the time of year all the new stuff hits the market?

[dgrammatiko]

@PhilETaylor if you were waiting one week more: http://www.macrumors.com/2016/10/22/kuo-october-2016-mac-predictions/

[brianteeman]

I have updated the title

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12500.}

[dgrammatiko]

@ciar4n can you take a look at this issue?

[ciar4n]

Unable test at the moment but I'm guessing the issue is here which would only effect high pixel density displays.. https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435

If so, zooming in a couple of notches in any browser should replicate the issue? I can put in a PR to fix tomorrow.

[andrepereiradasilva]

@ciar4n you nailed it, zoomed the page a lot in chrome and widonwss and was able to reproduce it

[dgrammatiko]

@ciar4n I thought we were using the mootools icon by now for chosen...

[ciar4n]

Thank you @andrepereiradasilva .. removing that CSS should resolve it so. Alternatively I can override it in the template.css so as to keep the chosen.css to the original.

@DGT41 Yes, we are using the mootools/icomoon icon. That CSS is loading a 2x sprite for retina displays using '!important' which is overriding the CSS used to remove the sprite, hence the double icons (one the icomoon icon, the other the original sprite image).

[zero-24]

Closing as there is a PR #12528 for this please test on retina.

[brianteeman]

This video is private

I am not saying I dont believe you are seeing this I am just saying I
cannot replicate it

On 22 October 2016 at 20:25, Phil Taylor [email protected] wrote:

This is what I did - again, to record the video, and again, it replicated
the issue.

https://www.youtube.com/watch?v=ayetRwMA6IA

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Rdrp2caMcHLN-_kGykab92g-HtMks5q2mMOgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

[brianteeman]

Bingo - I can replicate it now on chrome if I "massively" zoom in

On 22 October 2016 at 22:40, Ciaran Walsh [email protected] wrote:

Unable test at the moment but I'm guessing the issue is here which would
only effect high pixel density displays.. https://github.com/joomla/
joomla-cms/blob/3.7.x/media/jui/css/chosen.css#L435

If so, zooming in a couple of notches in any browser should replicate the
issue? I can put in a PR to fix tomorrow.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12500 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ap3ukJtXwpNTKsNRmqm3D-PbgS1ks5q2oLDgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

[brianteeman]

On my phone so can't test but http://stackoverflow.com/questions/15551287/how-to-test-a-website-for-retina-on-windows-without-an-actual-retina-display

[brianteeman]

Ok so we can confirm this as an issue on retina displays then. Can this be emulated on non retina displays

[brianteeman]

Iirc the chosen update that I did was merged into 3.6.3 but aspects of it were overwritten in the "flat paint" pr. So I would look at those overrides of chosen first before looking at chosen itself

[brianteeman]

I'm assuming from the comments that it will be any retina device.

[brianteeman]

I do not have a retina screen

[brianteeman]

What am I supposed to be seeing as messy?

On 21 October 2016 at 16:49, Valentín [email protected] wrote:

Steps to reproduce the issue

Create or edit an article, and see the icons on the right side for the
dropdowns such as "Access" or "Published"
Expected result Actual result

[image: 1]
https://cloud.githubusercontent.com/assets/4999794/19604664/dfb16996-977b-11e6-8d80-9ff6b8afcb2f.jpg
[image: 2]
https://cloud.githubusercontent.com/assets/4999794/19604669/e21de4c0-977b-11e6-8b5f-336444e441b7.jpg
System information (as much as possible)

Using Joomla 3.7.x branch
Firefox browser
Mac OS
Additional comments

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12500, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WVPizKz-uk1LGCFJEj9QnqxsRIcks5q2N8LgaJpZM4KdX4L
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

[htmgarcia]

If I wasn't clear, this happens with 3.7.x branch.
I have a retina display Macbook Pro (can't confirm if happens on these screens only)

[htmgarcia]

Thanks @PhilETaylor!
Tested #12528, the issue is solved in my end.

Awesome job, everyone!