Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pagination list rendering to layout #10982

Closed
wants to merge 6 commits into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jul 1, 2016

Summary of Changes

The pagination list rendering is moved to a layout.

Testing Instructions

  • Create a lot of articles with featured set to yes
  • Open the site on the front

On the default start page on the bottom should the pagination list be shown. The list should look the same as without the patch.

@mbabker
Copy link
Contributor

mbabker commented Jul 1, 2016

If you're going to do this then the pagination_list_render() overriding function should be deprecated as well. Otherwise you get into the whole "there are multiple ways to override this and depending on which way your template has chosen can affect how you edit it" thing.

/*
* @deprecated The list rendering is now a layout.
* @see JPagination::_list_render()
*/
if (function_exists('pagination_list_render'))
{
$listOverride = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a JLog statement in this if conditional too? That way it gets picked up by anyone with deprecation logging enabled.

@laoneo
Copy link
Member Author

laoneo commented Jul 1, 2016

Did add a deprecate message with commit bfc2799.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 79a7ee5

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@yvesh
Copy link
Member

yvesh commented Jul 4, 2016

I have tested this item ✅ successfully on 79a7ee5

works as expected

Before:
screenshot 2016-07-04 20 57 25

After:
screenshot 2016-07-04 20 58 04


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 5, 2016
@laoneo laoneo changed the title Move pagination list rendering to layou Move pagination list rendering to layout Jul 5, 2016
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @andrepereiradasilva, @yvesh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 7731ef8

just unit test changed.
no change in behaviour


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@laoneo
Copy link
Member Author

laoneo commented Jul 6, 2016

IMO it doesn't need testing again as I simplified the unit tests only.

@brianteeman
Copy link
Contributor

Remove RTC for now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 6, 2016
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 7731ef8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@laoneo
Copy link
Member Author

laoneo commented Jul 6, 2016

Thanks for testing again.

@brianteeman
Copy link
Contributor

back to rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 6, 2016
@brianteeman brianteeman modified the milestone: Joomla 3.7.0 Jul 11, 2016
See PR Digital-Peak-Incubator/tpl_tauristar#94
@laoneo
Copy link
Member Author

laoneo commented Jul 21, 2016

Last commit improved code style from PR @ Digital-Peak-Incubator/tpl_tauristar#94.

@wilsonge
Copy link
Contributor

Merged with c34cdd8 - Thanks!

@wilsonge wilsonge closed this Jul 30, 2016
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@laoneo laoneo deleted the pagination-list-layout branch August 9, 2016 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants