-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pagination list rendering to layout #10982
Conversation
If you're going to do this then the |
/* | ||
* @deprecated The list rendering is now a layout. | ||
* @see JPagination::_list_render() | ||
*/ | ||
if (function_exists('pagination_list_render')) | ||
{ | ||
$listOverride = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a JLog statement in this if conditional too? That way it gets picked up by anyone with deprecation logging enabled.
Did add a deprecate message with commit bfc2799. |
I have tested this item ✅ successfully on 79a7ee5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
I have tested this item ✅ successfully on 79a7ee5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
This PR has received new commits. CC: @andrepereiradasilva, @yvesh This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
I have tested this item ✅ successfully on 7731ef8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
IMO it doesn't need testing again as I simplified the unit tests only. |
Remove RTC for now This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
I have tested this item ✅ successfully on 7731ef8 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
Thanks for testing again. |
back to rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10982. |
See PR Digital-Peak-Incubator/tpl_tauristar#94
Last commit improved code style from PR @ Digital-Peak-Incubator/tpl_tauristar#94. |
Merged with c34cdd8 - Thanks! |
Summary of Changes
The pagination list rendering is moved to a layout.
Testing Instructions
On the default start page on the bottom should the pagination list be shown. The list should look the same as without the patch.