Media select all #8852

okonomiyaki3000 · 2016-01-07T08:17:47Z

Adding a "select all" box in the media list view. At the moment, the only batch operation that can be performed in this view is "delete" so the main point of this is to make it easier when you have a folder full of things that you need to delete.

Testing

It works like any other "select all" box so, to test it, just go to a media folder that has multiple items in it and check the box. You should see that they all become selected. Uncheck the box, they will all be deselected. It works both ways so you can also check all item checkboxes and you should see that the "select all" becomes selected automatically, deselect one of the item checkboxes and the "select all" becomes deselected.

More?

It seems to me that it would be nice to be able to select not only "all" but also on the basis of type. This is almost trivial because this view already treats folders, images, videos, and other documents as separate groups. In fact, it can be done relatively easily but it doesn't work as perfectly as I'd like due to limitations of the Joomla core js. Honestly, some of those functions are just not super great. Perhaps someone will completely rewrite them in the future and then these additional features can be easily added.

rogerhoen · 2016-01-10T10:22:24Z

I have tested this item ✅ successfully on 27f3371

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-01-21T12:33:58Z

I have tested this item 🔴 unsuccessfully on 27f3371

The select and delete work but the message is wrong
It only shows

Message
Delete Complete: /sampledata/fruitshop/tamarind.jpg

It would be better if it was to say something like "Multiple selected files deleted"

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

okonomiyaki3000 · 2016-01-22T00:23:14Z

Ah, good catch. I'll fix this.

okonomiyaki3000 · 2016-01-22T00:44:12Z

@brianteeman Actually... that has nothing to do with this PR. Multiple selection/deletion is already a thing and this poor message is the status quo. I can fix it in this PR though.

joomla-cms-bot · 2016-01-22T01:12:46Z

This PR has received new commits.

CC: @brianteeman, @NLRoosj

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

okonomiyaki3000 · 2016-01-22T01:21:37Z

I'm updating both the 'file' controller and the 'folder' controller to report all deleted files and folders but, in fact, the 'file' controller is never actually used. Actually, a lot of things in this component are outdated or could use some work. For example, JError is still used quite a lot.

infograf768 · 2016-01-22T09:48:04Z

print_r($app); die();

😃

brianteeman · 2016-01-22T09:50:21Z

The component is scheduled for replacement but I guess not till 3.6 now

On 22 January 2016 at 09:48, infograf768 [email protected] wrote:

print_r($app); die();

[image: 😃]

—
Reply to this email directly or view it on GitHub
#8852 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

okonomiyaki3000 · 2016-01-22T11:20:29Z

lol! Epic fail.

joomla-cms-bot · 2016-01-25T00:05:21Z

This PR has received new commits.

CC: @brianteeman, @NLRoosj

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-01-26T13:28:08Z

I have tested this item ✅ successfully on 6c71696

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

genesisfan · 2016-02-19T14:52:34Z

I have tested this item ✅ successfully on 6c71696

It works like a charm!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-02-19T16:41:35Z

RTC thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

wilsonge · 2016-02-23T11:02:47Z

I'm sorry @okonomiyaki3000 but there are conflicts - so I can't merge it - can you rebase please?

joomla-cms-bot · 2016-02-24T03:02:41Z

This PR has received new commits.

CC: @brianteeman, @genesisfan, @NLRoosj

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

rdeutz · 2016-04-13T05:38:31Z

This is a new feature so it has to go into 3.6.x ?

brianteeman · 2016-04-13T06:10:39Z

Personally its more of a bug fix than a feature as this should have always been there and it cant be said to have any effect in anything else.

rdeutz · 2016-04-13T06:25:22Z

"It should have been there" fits for or lot of issues :-)

Anyway I checked the last commits, there are files renamed, so when someone has overwritten a layout it fails (chances are low I know). I also think it should be testet again.

If we are strict with semver then this is a interface change and allows a different way of doing something so it isn't bugfix it is a new way and so it is a new feature.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-04-13T06:41:56Z

Wow - didnt actually spot that this (small change) had so many edits. Seeing all the file changes I agree with you 3.6 and will retest

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-04-13T06:51:00Z

I have tested this item 🔴 unsuccessfully on 2c272f1

Came across a problem when deleting invalid files

Create a file caled test (1).jpg and add to the images folder manually

If you try to delete it you will correctly get a message
Unable to delete: . File name must only contain alphanumeric characters and no spaces.

Now try to use the delete all checkbox on the folder and you get a message
Unable to delete: .

When you try to delete multiple files you get a success message for each file with the filename as expected
But if you have multiple files that cannot be deleted like above then you only get the one message
Unable to delete: .

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

roland-d · 2016-05-07T12:55:41Z

I am in the loop for the new Media Manager as well, work is being done for it but it isn't implemented until finished. Until then I would like to see this go in as it enhances the user experience.

@okonomiyaki3000 Could you please brush op this PR so we can get it tested and merged? Thank you.

P.s. if you are interested in contributing to the new media manager, let me know.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

okonomiyaki3000 · 2016-05-09T00:34:38Z

I'll get this PR ready then. I might be interested in the new one but not sure if I have much time to work on it.

roland-d · 2016-05-09T06:18:28Z

@okonomiyaki3000 Thank you, I will let Jisse contact you and you guys can figure it out the options.

…files now

okonomiyaki3000 · 2016-05-09T08:36:17Z

@brianteeman In the case that you try to delete a badly named file along with some properly named files, do you think it's best to abort all delete operations or just skip the badly named file(s)?

joomla-cms-bot · 2016-05-09T09:35:38Z

This PR has received new commits.

CC: @brianteeman, @genesisfan, @NLRoosj

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

okonomiyaki3000 · 2016-05-09T09:44:55Z

For now, I've gone with deleting what can be deleted and displaying errors for what can't but I wrote it in such a way that it's very simple to abort before deleting anything in case of errors.

There's something else to consider though. We decide which files are good and which files are bad before firing any events. We then warn about the bad files and do nothing else with them. The good files get events fired for them at which time path to the file to delete can be changed (by a a plugin). So, a good path may become bad (because of a plugin) but a bad path has no chance to be made good.

Also, MediaControllerFile and MediaControllerFolder both have identical delete functions. One is used when deleting a single file, the other for multiple. It's kind of nonsense. I'm not going to fix it now because it's not a big deal and anyway a new media manager is being developed. Let's hope we can avoid this kind of thing in the new one.

brianteeman · 2016-05-13T07:54:47Z

I have tested this item ✅ successfully on 3ec14a0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

ghost · 2016-06-10T15:38:58Z

I have tested this item ✅ successfully on 3ec14a0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

brianteeman · 2016-06-10T15:49:32Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8852.}

wilsonge · 2016-07-30T13:53:29Z

Merged with c0aadb2. Thanks!

brianteeman · 2016-07-30T13:56:16Z

Changed milestone as it was merged early

wilsonge · 2016-07-30T13:59:42Z

3.7.x branch :)

brianteeman · 2016-07-30T14:00:16Z

Oops my mistake. Github doesn't show the bramch

joomla-cms-bot added the PR-staging label Jan 7, 2016

okonomiyaki3000 force-pushed the media-select-all branch from ab719f4 to 6c71696 Compare January 25, 2016 00:05

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 19, 2016

okonomiyaki3000 force-pushed the media-select-all branch from 6c71696 to 2c272f1 Compare February 24, 2016 03:02

brianteeman modified the milestone: Joomla 3.5.2 Apr 12, 2016

rdeutz modified the milestones: Joomla! 3.6.0, Joomla 3.5.2 Apr 13, 2016

rdeutz added Feature and removed RTC This Pull Request is Ready To Commit labels Apr 13, 2016

okonomiyaki3000 added 3 commits May 9, 2016 17:15

Add a 'check all' box for media lists

d43ab4f

rename template files as plural because loops are handled inside the …

de2090a

…files now

Display a message for each deleted file, not just the last one.

6edd802

Display proper messages when failing to delete badly named files.

3ec14a0

okonomiyaki3000 force-pushed the media-select-all branch from 2c272f1 to 3ec14a0 Compare May 9, 2016 09:35

wilsonge removed this from the Joomla 3.6.0 milestone Jun 8, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2016

roland-d added this to the Joomla 3.7.0 milestone Jun 10, 2016

wilsonge pushed a commit that referenced this pull request Jul 30, 2016

Add a 'check all' box for media lists. Fixes #8852

c0aadb2

wilsonge closed this Jul 30, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016

brianteeman modified the milestones: Joomla 3.6.1, Joomla 3.7.0 Jul 30, 2016

wilsonge modified the milestones: Joomla 3.7.0, Joomla 3.6.1 Jul 30, 2016

brianteeman mentioned this pull request Mar 29, 2017

few files to remove #13519

Closed

okonomiyaki3000 deleted the media-select-all branch May 29, 2017 04:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Media select all #8852

Media select all #8852

okonomiyaki3000 commented Jan 7, 2016 •

edited by brianteeman

Loading

rogerhoen commented Jan 10, 2016

brianteeman commented Jan 21, 2016

okonomiyaki3000 commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

joomla-cms-bot commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

infograf768 commented Jan 22, 2016

brianteeman commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

joomla-cms-bot commented Jan 25, 2016

brianteeman commented Jan 26, 2016

genesisfan commented Feb 19, 2016

brianteeman commented Feb 19, 2016

wilsonge commented Feb 23, 2016

joomla-cms-bot commented Feb 24, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

brianteeman commented Apr 13, 2016

roland-d commented May 7, 2016

okonomiyaki3000 commented May 9, 2016

roland-d commented May 9, 2016

okonomiyaki3000 commented May 9, 2016

joomla-cms-bot commented May 9, 2016

okonomiyaki3000 commented May 9, 2016

brianteeman commented May 13, 2016

ghost commented Jun 10, 2016

brianteeman commented Jun 10, 2016

wilsonge commented Jul 30, 2016 •

edited

Loading

brianteeman commented Jul 30, 2016

wilsonge commented Jul 30, 2016

brianteeman commented Jul 30, 2016

Media select all #8852

Media select all #8852

Conversation

okonomiyaki3000 commented Jan 7, 2016 • edited by brianteeman Loading

Testing

More?

rogerhoen commented Jan 10, 2016

brianteeman commented Jan 21, 2016

okonomiyaki3000 commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

joomla-cms-bot commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

infograf768 commented Jan 22, 2016

brianteeman commented Jan 22, 2016

okonomiyaki3000 commented Jan 22, 2016

joomla-cms-bot commented Jan 25, 2016

brianteeman commented Jan 26, 2016

genesisfan commented Feb 19, 2016

brianteeman commented Feb 19, 2016

wilsonge commented Feb 23, 2016

joomla-cms-bot commented Feb 24, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

brianteeman commented Apr 13, 2016

roland-d commented May 7, 2016

okonomiyaki3000 commented May 9, 2016

roland-d commented May 9, 2016

okonomiyaki3000 commented May 9, 2016

joomla-cms-bot commented May 9, 2016

okonomiyaki3000 commented May 9, 2016

brianteeman commented May 13, 2016

ghost commented Jun 10, 2016

brianteeman commented Jun 10, 2016

wilsonge commented Jul 30, 2016 • edited Loading

brianteeman commented Jul 30, 2016

wilsonge commented Jul 30, 2016

brianteeman commented Jul 30, 2016

okonomiyaki3000 commented Jan 7, 2016 •

edited by brianteeman

Loading

wilsonge commented Jul 30, 2016 •

edited

Loading