Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GitLabWebHook #207

Closed
wants to merge 10 commits into from
Closed

Cleanup GitLabWebHook #207

wants to merge 10 commits into from

Conversation

coder-hugo
Copy link
Contributor

This PR cleans the code of the GitLabWebHook by splitting it into multiple classes.
The PR is based on #198.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@coder-hugo coder-hugo mentioned this pull request Feb 24, 2016
Closed
daddykotex
daddykotex reviewed Feb 24, 2016
View reviewed changes
src/main/java/com/dabsquared/gitlabjenkins/webhook/build/PushBuildAction.java

protected void buildOpenMergeRequests(final GitLabPushTrigger trigger, final Integer projectId, String projectRef) {
try {
GitLabConnectionProperty property = project.getProperty(GitLabConnectionProperty.class);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you got it fixed here!

@omehegan omehegan mentioned this pull request Feb 25, 2016
Closed
@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch 5 times, most recently from 3303a7b to 6b99f63 Compare February 27, 2016 20:33
@coder-hugo
Copy link
Contributor Author

@slide, @markus-mnm: @omehegan told me that you are more experienced in Java/Jenkins plugin development than he. Could you please have a look to my changes before I merge them back? As you can see in the description of the PR this is based on another PR (which is also based on another PR 😉) So you can decide whether you want to review my whole changes or to review smaller changes by reviewing the PRs in that order: #192, #198, this one.
If you like you can already have a look to #203 which will be one of my next cleanups.

Thanks,
coder-hugo

@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch from 6b99f63 to f2e0f27 Compare March 2, 2016 20:16
coder-hugo added 10 commits March 10, 2016 22:06
@coder-hugo
Move commit status handling to a Notifier extension
887583f
@coder-hugo
Use correct spelling of autoCompleteDelimChar attribute
d6bb94b
@coder-hugo
Add functionality to add the new publisher automatically to old jobs …
c457e13 
…if addCiMessage was activated for the GitLabPushTrigger
@coder-hugo
Add functionality to configure multiple GitLab instances
193285f
@coder-hugo
Move generation of status json and png to separate classes
cae85b9
@coder-hugo
Move all status related actions of the GitLabWebHook to separate classes
c53b68a
@coder-hugo
Move build actions of the GitLabWebHook to separate classes
296ecd5
@coder-hugo
Moved the resolution of the WebHookActions to a separate class
cf1f0ed
@coder-hugo
Move status images to the resources directory so they are easier to a…
d290997 
…ccess
@coder-hugo
Use status not_found instead of pending if there is currently no buil…
3d533fd 
…d for a given commit sha1 (fixes jenkinsci#159)
@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch from f2e0f27 to 3d533fd Compare March 10, 2016 21:10
@coder-hugo
Copy link
Contributor Author

Close this as there is no possibility to change the target branch. New PR #231

@coder-hugo coder-hugo closed this Mar 10, 2016
@markus-mnm
Copy link
Contributor

I'll have a look at this this weekend, but I might not provide as much value as one might hope.
( posted this to the wrong PR, but started looking at the right PR #231)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coder-hugo @jenkinsadmin @markus-mnm @jtheoof @daddykotex