Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GitLabWebHook #231

Merged

Conversation

coder-hugo
Copy link
Contributor

This PR cleans the code of the GitLabWebHook by splitting it into multiple classes.
The PR is based on #230

This was referenced Mar 10, 2016
@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch 2 times, most recently from b20e180 to 4b9943f Compare March 12, 2016 17:05
@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch from 4b9943f to 17f6fe9 Compare March 12, 2016 22:26
@markus-mnm
Copy link
Contributor

I had a look and like what I saw so far. I will try to do some testing tomorrow. Caveat: I have not been the master of my schedule for some time and I would not wait for my OK on this.

Regarding the test JSONS, I had a similar approach that I used locally. This PR's has more complete data, but I also used jsons from different versions of Gitlab to test some of the peculiarities of different versions.

Another thing I noticed so far is that some of the debug and info logging is gone. E.g. the request payload and such used to be useful to find problems with different versions. I still have to run this PR's code, so this might be a useless observation.

@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch from 17f6fe9 to d33426e Compare March 13, 2016 16:09
@coder-hugo coder-hugo force-pushed the feature/cleanup-gitlab-webhook branch from 0d019de to e3e29a3 Compare March 13, 2016 17:20
@coder-hugo coder-hugo added this to the 1.2.0 milestone Mar 15, 2016
@coder-hugo coder-hugo merged commit e3e29a3 into jenkinsci:release-1.2 Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants