-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup GitLabWebHook #231
Cleanup GitLabWebHook #231
Conversation
…if addCiMessage was activated for the GitLabPushTrigger
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
b20e180
to
4b9943f
Compare
…d for a given commit sha1 (fixes jenkinsci#159)
4b9943f
to
17f6fe9
Compare
I had a look and like what I saw so far. I will try to do some testing tomorrow. Caveat: I have not been the master of my schedule for some time and I would not wait for my OK on this. Regarding the test JSONS, I had a similar approach that I used locally. This PR's has more complete data, but I also used jsons from different versions of Gitlab to test some of the peculiarities of different versions. Another thing I noticed so far is that some of the debug and info logging is gone. E.g. the request payload and such used to be useful to find problems with different versions. I still have to run this PR's code, so this might be a useless observation. |
17f6fe9
to
d33426e
Compare
0d019de
to
e3e29a3
Compare
This PR cleans the code of the GitLabWebHook by splitting it into multiple classes.
The PR is based on #230