Add publishers to update the commit/merge request status in GitLab #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
3 times, most recently
from
f19a4f1 to
07245d7
Compare
coder-hugo
changed the title
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
from
07245d7 to
9c62979
Compare
coder-hugo
changed the title
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
2 times, most recently
from
fc2d23c to
dc018f4
Compare
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
2 times, most recently
from
f0c0019 to
d9961be
Compare
Closed
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
from
d9961be to
e8768c7
Compare
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
from
e8768c7 to
fc3ad7b
Compare
…if addCiMessage was activated for the GitLabPushTrigger
coder-hugo
force-pushed
the
feature/add-publishers-to-update-gitlab-status
branch
from
fc3ad7b to
c457e13
Compare
|
Close this as there is no possibility to change the target branch. New PR #229 |
exceed-alae
pushed a commit
to exceed-alae/gitlab-plugin
that referenced
this pull request
May 20, 2022
exceed-alae
pushed a commit
to exceed-alae/gitlab-plugin
that referenced
this pull request
May 20, 2022
GhprbPullRequestMerge must NOT persist and serialize logger jenkinsci#192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the configuration (and execution) of the GitLab commit status updates to a publisher ("Publish build status to GitLab commit (GitLab 8.1+ required)"). With this change its possible to trigger builds manually without adding any special parameter and the status of the corresponding commit in GitLab gets updated. Additionally there is a XStream converter that migrates the configuration of old jobs to use this publisher automatically depending on their GitLabPushTrigger's configuration.
There is just one thing missing of the previous functionality: The commit status "pending" will not be sent to GitLab. The reason for this is that I haven't found any extension point that throws an event or something similar if a build was triggered but not yet started.
Fixes #162