Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build to be triggered when pushing to an Open MR #208

Closed
wants to merge 1 commit into from

Conversation

daddykotex
Copy link

The function generateMergeRequestBuild return when it should not be if the state
equals to "update". I removed the check to allow the build to be triggered.

I also used StringUtils.isEmpty to perform a check in GitLabWebHook to avoid a NPE.

The function generateMergeRequestBuild return when it should not be if the state
equals to "update". I removed the check to allow the build to be triggered.

I also used StringUtils.isEmpty to perform a check in GitLabWebHook to avoid a NPE.
@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@jtheoof
Copy link

jtheoof commented Feb 24, 2016

Looks good, seems to be fixing #90 Works fine with our dev environment.

@coder-hugo
Copy link
Contributor

Open MRs will be triggered already by pushing to the corresponding branch if the option "Rebuild open Merge Requests" is set at least to "On push to source branch" (Tested with GitLab 7.14.3 and GitLab 8.4.3 using the code of PR #207 which should mainly contain code cleanups and no bug fixes)
If we use the update Merge Request Event to trigger builds for a open MR (which IMHO is the cleaner way as we don't need to figure out the MR for an incoming Push Event) we should remove the code that triggers a new MR build in case of a Push Event.

@daddykotex
Copy link
Author

Looks like @coder-hugo did all the work in #207 , thank you for that!

@daddykotex daddykotex closed this Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants